hedera-services icon indicating copy to clipboard operation
hedera-services copied to clipboard

build(deps): bump junit5 from 5.10.2 to 5.12.2 in /hiero-dependency-versions

Open dependabot[bot] opened this issue 1 year ago • 25 comments

Bumps junit5 from 5.10.2 to 5.11.4. Updates org.junit.jupiter:junit-jupiter-api from 5.10.2 to 5.11.4

Release notes

Sourced from org.junit.jupiter:junit-jupiter-api's releases.

JUnit 5.11.4 = Platform 1.11.4 + Jupiter 5.11.4 + Vintage 5.11.4

See Release Notes.

Full Changelog: https://github.com/junit-team/junit5/compare/r5.11.3...r5.11.4

JUnit 5.11.3 = Platform 1.11.3 + Jupiter 5.11.3 + Vintage 5.11.3

See Release Notes.

Full Changelog: https://github.com/junit-team/junit5/compare/r5.11.2...r5.11.3

JUnit 5.11.2 = Platform 1.11.2 + Jupiter 5.11.2 + Vintage 5.11.2

See Release Notes.

Full Changelog: https://github.com/junit-team/junit5/compare/r5.11.1...r5.11.2

JUnit 5.11.1 = Platform 1.11.1 + Jupiter 5.11.1 + Vintage 5.11.1

See Release Notes.

Full Changelog: https://github.com/junit-team/junit5/compare/r5.11.0...r5.11.1

JUnit 5.11.0 = Platform 1.11.0 + Jupiter 5.11.0 + Vintage 5.11.0

See Release Notes.

New Contributors

Full Changelog: https://github.com/junit-team/junit5/compare/r5.10.3...r5.11.0

JUnit 5.11.0-RC1 = Platform 1.11.0-RC1 + Jupiter 5.11.0-RC1 + Vintage 5.11.0-RC1

... (truncated)

Commits
  • 6430ba4 Release 5.11.4
  • d093121 Finalize 5.11.4 release notes
  • 0444353 Fix Maven integration tests on JDK 24
  • b5c7f4e Move #4153 to 5.11.4 release notes
  • b20c4e2 Ensure the XMLStreamWriter is closed after use
  • 6376f0a Configure Git username and email
  • 2b485c4 Set reference repo URI
  • 500b5a0 Inject username and password via new DSL
  • d671961 Update plugin gitPublish to v5
  • 3d11279 Add JAVA_25 to JRE enum
  • Additional commits viewable in compare view

Updates org.junit.jupiter:junit-jupiter-engine from 5.10.2 to 5.11.4

Release notes

Sourced from org.junit.jupiter:junit-jupiter-engine's releases.

JUnit 5.11.4 = Platform 1.11.4 + Jupiter 5.11.4 + Vintage 5.11.4

See Release Notes.

Full Changelog: https://github.com/junit-team/junit5/compare/r5.11.3...r5.11.4

JUnit 5.11.3 = Platform 1.11.3 + Jupiter 5.11.3 + Vintage 5.11.3

See Release Notes.

Full Changelog: https://github.com/junit-team/junit5/compare/r5.11.2...r5.11.3

JUnit 5.11.2 = Platform 1.11.2 + Jupiter 5.11.2 + Vintage 5.11.2

See Release Notes.

Full Changelog: https://github.com/junit-team/junit5/compare/r5.11.1...r5.11.2

JUnit 5.11.1 = Platform 1.11.1 + Jupiter 5.11.1 + Vintage 5.11.1

See Release Notes.

Full Changelog: https://github.com/junit-team/junit5/compare/r5.11.0...r5.11.1

JUnit 5.11.0 = Platform 1.11.0 + Jupiter 5.11.0 + Vintage 5.11.0

See Release Notes.

New Contributors

Full Changelog: https://github.com/junit-team/junit5/compare/r5.10.3...r5.11.0

JUnit 5.11.0-RC1 = Platform 1.11.0-RC1 + Jupiter 5.11.0-RC1 + Vintage 5.11.0-RC1

... (truncated)

Commits
  • 6430ba4 Release 5.11.4
  • d093121 Finalize 5.11.4 release notes
  • 0444353 Fix Maven integration tests on JDK 24
  • b5c7f4e Move #4153 to 5.11.4 release notes
  • b20c4e2 Ensure the XMLStreamWriter is closed after use
  • 6376f0a Configure Git username and email
  • 2b485c4 Set reference repo URI
  • 500b5a0 Inject username and password via new DSL
  • d671961 Update plugin gitPublish to v5
  • 3d11279 Add JAVA_25 to JRE enum
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dependabot[bot] avatar Dec 18 '24 19:12 dependabot[bot]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.01% (target: -1.00%) :white_check_mark:
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d47af541e9b714e425d2dd9b5ff2d889849ada17) 95934 65316 68.08%
Head commit (305cfd78e6177a886e4e04a304a4c4e98fc7f10b) 95934 (+0) 65324 (+8) 68.09% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17125) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

codacy-production[bot] avatar Dec 18 '24 19:12 codacy-production[bot]

@dependabot rebase

rbarker-dev avatar Jan 02 '25 19:01 rbarker-dev

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dependabot[bot] avatar Jan 02 '25 19:01 dependabot[bot]

@dependabot recreate

rbarker-dev avatar Jan 02 '25 19:01 rbarker-dev

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.91%. Comparing base (108b874) to head (f4c075f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17125      +/-   ##
============================================
- Coverage     68.92%   68.91%   -0.01%     
+ Complexity    22986    22985       -1     
============================================
  Files          2647     2647              
  Lines         99445    99445              
  Branches      10285    10285              
============================================
- Hits          68544    68535       -9     
- Misses        27023    27027       +4     
- Partials       3878     3883       +5     

see 11 files with indirect coverage changes

Impacted file tree graph

codecov[bot] avatar Jan 02 '25 23:01 codecov[bot]

@dependabot rebase

andrewb1269 avatar Jan 03 '25 00:01 andrewb1269

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dependabot[bot] avatar Jan 03 '25 00:01 dependabot[bot]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.07% (target: -1.00%) :white_check_mark:
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aab4135f9ca3622f7cf921aa24dd10edd40e5ffa) 96080 68377 71.17%
Head commit (f8c19fd19f9a0d14f0731e724a9819195bcce897) 96080 (+0) 68310 (-67) 71.10% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17125) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

codacy-production[bot] avatar Jan 03 '25 01:01 codacy-production[bot]

@dependabot recreate

jjohannes avatar Jan 06 '25 17:01 jjohannes

@dependabot rebase

mishomihov00 avatar Jan 07 '25 11:01 mishomihov00

@dependabot rebase

mishomihov00 avatar Jan 09 '25 08:01 mishomihov00

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot[bot] avatar Jan 09 '25 17:01 dependabot[bot]

@dependabot rebase

rbarker-dev avatar Jan 16 '25 21:01 rbarker-dev

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.05% (target: -1.00%) :white_check_mark:
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2bd891942a027f238e9fe2f77da4a570d92a43aa) 98733 72014 72.94%
Head commit (f6be71c1651ea34f1f3008206ba6a6335b0c68f5) 98733 (+0) 72065 (+51) 72.99% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17125) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

codacy-production[bot] avatar Jan 16 '25 22:01 codacy-production[bot]

@dependabot rebase

jjohannes avatar Jan 29 '25 07:01 jjohannes

@dependabot recreate

jjohannes avatar Jan 31 '25 21:01 jjohannes

It looks like something in the JUnit update is causing some of the HAPI tests to hang/fail. This is also happening in #17242 which implicitly pulls up the JUnit version as well.

jjohannes avatar Jan 31 '25 22:01 jjohannes

I can't reproduce the problem locally. Maybe it's some scheduling/load issue with parallel tests. I'll push different JUnit versions to this PR narrow down with which version the issue starts to appear.

jjohannes avatar Feb 03 '25 15:02 jjohannes

The first version where the issue shows up is 5.10.4. I suspect this change to be responsible:

New Features and Improvements

  • Improve parallelism and reduce number of blocked threads in the presence of @Isolated tests when parallel execution is enabled

~It's likely that we get more parallelism in the HAPI tests thanks to that improvement. They may actually get faster overall. However, the test clients regularly fail to connect. Reason could be too much tests running in parallel blocking each other for too long. Whatever it is, it would be great to get the test client setup stable enough to handle this. It may reduce the general flakiness of the HAPI tests. Other "brute force" solution could be to limit the parallelism by further reducing XX:ActiveProcessorCount=6 more or some other JUnit parallelism configuration property.~

Looks like this is consistently affecting all @OrderedInIsolation tests.

Maybe some timing issue in the setup? As far as I can tell from the logs, the network in not available when the test wants to send requests, although awaitReady seems to have returned successfully. Stack Trace

A small test set having this issue is hapiTestRestart. But running that locally works for me.

You can get all the logs for the failed runs from the CI runs associated with the different commits on this PR.

jjohannes avatar Feb 04 '25 08:02 jjohannes

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.01% (target: -1.00%) :white_check_mark:
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (88c39cfc54018f6cf1afe7e052a7bf92f423fe15) 104315 78021 74.79%
Head commit (07c9ccc338ece4bab303369265a3a17f98f01574) 104315 (+0) 78012 (-9) 74.79% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17125) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

codacy-production[bot] avatar Feb 04 '25 08:02 codacy-production[bot]

@dependabot rebase

andrewb1269 avatar Apr 15 '25 13:04 andrewb1269

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dependabot[bot] avatar Apr 15 '25 13:04 dependabot[bot]

:white_check_mark: Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
:white_check_mark: Open Source Security 0 0 0 0 0 issues

:computer: Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

lfdt-bot avatar Nov 06 '25 15:11 lfdt-bot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17125      +/-   ##
============================================
- Coverage     70.89%   70.89%   -0.01%     
- Complexity    24432    24434       +2     
============================================
  Files          2668     2668              
  Lines        104410   104410              
  Branches      10966    10966              
============================================
- Hits          74020    74017       -3     
- Misses        26344    26353       +9     
+ Partials       4046     4040       -6     

see 17 files with indirect coverage changes

Impacted file tree graph

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 06 '25 16:11 codecov[bot]

The issue we haven that exists since (see this comment) is still present with the latest JUnit 6.0.1.

jjohannes avatar Nov 06 '25 16:11 jjohannes