hedera-services icon indicating copy to clipboard operation
hedera-services copied to clipboard

build: sort Gradle config into more reusable pieces with less redundancy

Open jjohannes opened this issue 1 year ago • 2 comments

Description:

As preparation to move things into a separate repository. (WiP)

Candidates for separate PRs:

  • move:gradle/versions
  • move gradle/aggregation and use for consistent resolution
  • Publishing, developers.properties, description.txt
  • gradle/jdk-version.txt

Related issue(s):

#14255

Notes for reviewer:

Checklist

  • [ ] Documented (Code comments, README, etc.)
  • [ ] Tested (unit, integration, etc.)

jjohannes avatar Aug 30 '24 09:08 jjohannes

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +2.07% (target: -1.00%) :white_check_mark:
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (753d1be0907a558dbc2e00e2609f3d8930eda15b) 98565 64922 65.87%
Head commit (9239739df0d550ae654834c715c50daaedf3b7e6) 95563 (-3002) 64921 (-1) 67.94% (+2.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15282) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

codacy-production[bot] avatar Sep 06 '24 15:09 codacy-production[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.19%. Comparing base (753d1be) to head (9239739). Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #15282      +/-   ##
=============================================
- Coverage      64.19%   64.19%   -0.01%     
- Complexity     20815    20817       +2     
=============================================
  Files           2548     2548              
  Lines          95800    95800              
  Branches       10028    10028              
=============================================
- Hits           61498    61496       -2     
- Misses         30687    30688       +1     
- Partials        3615     3616       +1     

see 8 files with indirect coverage changes

Impacted file tree graph

codecov[bot] avatar Sep 06 '24 15:09 codecov[bot]

Playing ping-pong with Dependabot with the PR... needed to rebase several times due to conflicts with version updates.

Could you please restore your approval so that we get this in before the next conflict blocks it again.

@thomas-swirlds-labs @rbarkerSL @Neeharika-Sompalli @lpetrovic05 @mhess-swl @vtronkov

Much appreciated. 🙏

jjohannes avatar Dec 17 '24 07:12 jjohannes