hedera-services icon indicating copy to clipboard operation
hedera-services copied to clipboard

Address future/todo comments that are blocked or need further investigation

Open lukelee-sl opened this issue 6 months ago • 0 comments

Address the following future/todo messages

app/service/contract/impl/test/handlers/ContractCreateHandlerTest.java 134 // FUTURE: uncomment this after JKey removal unknown what this is about
app/service/contract/impl/exec/gas/CustomGasCalculator.java 98 * FUTURE, Gas for system contract method calls needs to be a) determined by measurement of Blocked until after fee calculation revamp
app/service/contract/impl/exec/TransactionProcessor.java 218 // (FUTURE) Once fee charging is more consumable in the HandleContext, we will also want Blocked until HandleContext changes
app/service/contract/impl/exec/systemcontracts/has/isauthorizedraw/IsAuthorizedRawCall.java 200 // FUTURE, Get the Cryptography engine from the services app via the context (needs to be invented) Blocked until HIP 632
app/service/contract/impl/exec/systemcontracts/has/isauthorizedraw/IsAuthorizedRawCall.java 250 // FUTURE, Determine if in fact input v ever has a EIP-155 encoded chain id ... Blocked until HIP 632
app/service/contract/impl/exec/utils/ActionStack.java 348 // (FUTURE) Use builder for simplicity when PBJ lets us set the oneof recipient to UNSET; blocked until https://github.com/hashgraph/pbj/issues/160
app/service/contract/impl/exec/scope/HandleHederaOperations.java 230 // (FUTURE) Needed before enabling contract expiry blocked until rent
app/service/contract/impl/infra/RentCalculator.java 58 // TODO - fix this before expiry and rent are enabled blocked until rent
app/service/contract/impl/state/DispatchingEvmFrameState.java 83 * TODO - get a little further to clarify DI strategy, then bring back a code cache. investigate
app/service/contract/impl/exec/systemcontracts/FullResult.java 70 // Future change reason.protoName() with reason.protoOrdinal() Investigate
app/service/contract/impl/exec/processors/CustomContractCreationProcessor.java 121 // TODO - check if a code rule failed before proceeding investigate
app/service/contract/impl/exec/processors/CustomContractCreationProcessor.java 143 // TODO - should we revert child records here? investigate
app/service/contract/impl/exec/failure/CustomExceptionalHaltReason.java 59 // FUTURE: refactor in the future to be more readable when we start looking for cleanups cannot be address until grade upgrade per https://github.com/autonomousapps/dependency-analysis-gradle-plugin/issues/1150
app/service/contract/impl/exec/scope/QueryHederaOperations.java 135 // TODO - implement correctly

lukelee-sl avatar Aug 08 '24 04:08 lukelee-sl