hedera-services icon indicating copy to clipboard operation
hedera-services copied to clipboard

chore: Improve unit test coverage on CryptoAddLiveHashHandler, CryptoApproveAllowanceHandler

Open mhess-swl opened this issue 9 months ago • 8 comments

Closes #13187

mhess-swl avatar May 10 '24 20:05 mhess-swl

Node: HAPI Test (Restart) Results

2 tests   2 :white_check_mark:  8m 4s :stopwatch: 2 suites  0 :zzz: 2 files    0 :x:

Results for commit 931d73c4.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '24 21:05 github-actions[bot]

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 :white_check_mark:  9m 6s :stopwatch: 2 suites  0 :zzz: 2 files    0 :x:

Results for commit 931d73c4.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '24 21:05 github-actions[bot]

Node: HAPI Test (Token) Results

235 tests   233 :white_check_mark:  22m 42s :stopwatch:  17 suites    2 :zzz:  17 files      0 :x:

Results for commit 931d73c4.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '24 21:05 github-actions[bot]

Node: HAPI Test (Misc) Results

464 tests   454 :white_check_mark:  43m 23s :stopwatch:  77 suites   10 :zzz:  77 files      0 :x:

Results for commit 931d73c4.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '24 21:05 github-actions[bot]

Node: HAPI Test (Crypto) Results

335 tests   335 :white_check_mark:  43m 52s :stopwatch:  25 suites    0 :zzz:  25 files      0 :x:

Results for commit 931d73c4.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '24 21:05 github-actions[bot]

Node: HAPI Test (Time Consuming) Results

21 tests   21 :white_check_mark:  54m 1s :stopwatch:  3 suites   0 :zzz:  3 files     0 :x:

Results for commit 931d73c4.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '24 21:05 github-actions[bot]

Node: Unit Test Results

  2 302 files  ± 0    2 302 suites  ±0   2h 23m 16s :stopwatch: - 1h 12m 21s 118 923 tests +10  118 856 :white_check_mark: +10  67 :zzz: ±0  0 :x: ±0  127 484 runs  +10  127 417 :white_check_mark: +10  67 :zzz: ±0  0 :x: ±0 

Results for commit 931d73c4. ± Comparison against base commit ea0b8751.

This pull request removes 4016 and adds 3789 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@e4ab217
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@64af8b95
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@7f5164dc
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@64e1de5e
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@a46c9efd
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@d729c483
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@5edbdcdb
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '24 22:05 github-actions[bot]

Node: HAPI Test (Smart Contract) Results

592 tests   591 :white_check_mark:  1h 14m 25s :stopwatch:  63 suites    0 :zzz:  63 files      1 :x:

For more details on these failures, see this check.

Results for commit 931d73c4.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 10 '24 22:05 github-actions[bot]

The 'HAPI Tests (Smart Contract)' failures have nothing to do with the unit test changes in this PR. Merging

mhess-swl avatar May 14 '24 20:05 mhess-swl