hedera-services
hedera-services copied to clipboard
docs: update token claim airdrop design doc
Description:
- Following up on comments from https://github.com/hashgraph/hedera-services/pull/12838
- Remove approach for dispatching child CryptoTransfer
- Describe check if the airdrop sender has approved token allowances
Checklist
- [ ] Documented (Code comments, README, etc.)
- [ ] Tested (unit, integration, etc.)
Node: HAPI Test (Restart) Results
3 tests 3 :white_check_mark: 5m 56s :stopwatch: 3 suites 0 :zzz: 3 files 0 :x:
Results for commit 00287770.
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Node Death Reconnect) Results
3 tests 3 :white_check_mark: 5m 58s :stopwatch: 3 suites 0 :zzz: 3 files 0 :x:
Results for commit 00287770.
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Token) Results
20 files 20 suites 5m 48s :stopwatch: 257 tests 257 :white_check_mark: 0 :zzz: 0 :x: 260 runs 260 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 00287770.
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Crypto) Results
23 files 23 suites 11m 38s :stopwatch: 350 tests 350 :white_check_mark: 0 :zzz: 0 :x: 356 runs 356 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 00287770.
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Misc) Results
51 files 51 suites 22m 50s :stopwatch: 357 tests 357 :white_check_mark: 0 :zzz: 0 :x: 374 runs 374 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 00287770.
:recycle: This comment has been updated with latest results.
Node: Unit Test Results
2 318 files ±0 2 318 suites ±0 3h 30m 56s :stopwatch: ±0s 112 665 tests ±0 112 596 :white_check_mark: ±0 69 :zzz: ±0 0 :x: ±0 121 176 runs ±0 121 107 :white_check_mark: ±0 69 :zzz: ±0 0 :x: ±0
Results for commit 00287770. ± Comparison against base commit c0b1e4f6.
This pull request removes 369 and adds 125 tests. Note that renamed tests count towards both.
IssuerDN: CN=s-aaaa
SubjectDN: CN=s-aaaa
Final Date: Fri Jan 01 00:00:00 UTC 2100
Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
Start Date: Sat Jan 01 00:00:00 UTC 2000
SerialNumber: 12482092706667292405
modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4]
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6]
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11]
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395]
Some Legal Characters
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [1] AddressBook {
Address[id=0,nickname=goB3yqpw,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=6535,hostnameExternal=243.246.33.105,portExternalIpv4=6535,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@6245f7a0,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@541439f4,memo=fK9iGgZD],
Address[id=2,nickname=2sK87pdt,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=62570,hostnameExternal=1…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@34910b0d, agrKeyPair=java.security.KeyPair@21d582fc, sigCert=[
[
Version: V3
Subject: CN=s-aaaa
Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12
Key: Sun RSA public key, 3072 bits
params: null
modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [2] AddressBook {
Address[id=0,nickname=VkuMiENM,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=29044,hostnameExternal=83.107.222.53,portExternalIpv4=29044,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@7198937f,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@3d6598cd,memo=IQd4Yd9G],
Address[id=3,nickname=gQdH7jMP,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=37016,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@22f2069c, agrKeyPair=java.security.KeyPair@8020711, sigCert= [0] Version: 3
SerialNumber: 12482092706667292405
IssuerDN: CN=s-aaaa
Start Date: Sat Jan 01 00:00:00 UTC 2000
Final Date: Fri Jan 01 00:00:00 UTC 2100
SubjectDN: CN=s-aaaa
Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [3] AddressBook {
Address[id=0,nickname=UVP6TXvs,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=60738,hostnameExternal=1.177.58.182,portExternalIpv4=60738,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@7779d208,agreeCert=<null>,memo=nm8rGle9],
Address[id=1,nickname=zqfaiKbZ,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=24626,hostnameExternal=221.66.8.238,portExternalIpv4=24626,sigPublicKey=<null>,agr…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@7864521c, agrKeyPair=java.security.KeyPair@6751f450, sigCert=[
[
Version: V3
Subject: CN=s-aaaa
Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12
Key: Sun RSA public key, 3072 bits
params: null
modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
Address[id=0,nickname=X3AyZtG2,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=40391,hostnameExternal=127.49.44.234,portExternalIpv4=40391,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@493277f4,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@18d7fb6a,memo=CJ8lNr7y],
Address[id=2,nickname=ZEcUNhbU,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=8577,hostnameExternal=3…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@a0bfb60, agrKeyPair=java.security.KeyPair@13b68a4d, sigCert=[
[
Version: V3
Subject: CN=s-aaaa
Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12
Key: Sun RSA public key, 3072 bits
params: null
modulus: 3993597839710083868231945175919139090761808006636174301522933223628513549165622405392179927490525437989266705657795380522223992433641724878847443931065713607200936674817049095003247060840820816825608104539722939764219883909214899161…
…
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Time Consuming) Results
19 tests 19 :white_check_mark: 21m 40s :stopwatch: 4 suites 0 :zzz: 4 files 0 :x:
Results for commit 00287770.
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Smart Contract) Results
67 files 67 suites 21m 26s :stopwatch: 604 tests 604 :white_check_mark: 0 :zzz: 0 :x: 631 runs 631 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 00287770.
:recycle: This comment has been updated with latest results.
Please add that we also need to update ApiPermissionConfig
and probably the different throttles.json
-files to include the new transaction.