hedera-services icon indicating copy to clipboard operation
hedera-services copied to clipboard

feat: real keys in fake address books

Open cody-littley opened this issue 9 months ago • 8 comments

closes #13133

cody-littley avatar May 09 '24 15:05 cody-littley

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 :white_check_mark:  7m 3s :stopwatch: 2 suites  0 :zzz: 2 files    0 :x:

Results for commit e58f9288.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 16:05 github-actions[bot]

Node: HAPI Test (Restart) Results

2 tests   2 :white_check_mark:  6m 4s :stopwatch: 2 suites  0 :zzz: 2 files    0 :x:

Results for commit e58f9288.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 16:05 github-actions[bot]

Node: HAPI Test (Token) Results

235 tests   234 :white_check_mark:  17m 40s :stopwatch:  17 suites    1 :zzz:  17 files      0 :x:

Results for commit e58f9288.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 16:05 github-actions[bot]

Node: HAPI Test (Misc) Results

459 tests   449 :white_check_mark:  41m 15s :stopwatch:  77 suites   10 :zzz:  77 files      0 :x:

Results for commit e58f9288.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 16:05 github-actions[bot]

Node: HAPI Test (Crypto) Results

335 tests   335 :white_check_mark:  39m 45s :stopwatch:  25 suites    0 :zzz:  25 files      0 :x:

Results for commit e58f9288.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 16:05 github-actions[bot]

Node: HAPI Test (Time Consuming) Results

21 tests   21 :white_check_mark:  54m 20s :stopwatch:  3 suites   0 :zzz:  3 files     0 :x:

Results for commit e58f9288.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 16:05 github-actions[bot]

Node: Unit Test Results

  2 280 files  +1    2 280 suites  +1   3h 17m 21s :stopwatch: -33s 118 789 tests +1  118 722 :white_check_mark: +2  67 :zzz: ±0  0 :x:  - 1  127 274 runs  +1  127 207 :white_check_mark: +2  67 :zzz: ±0  0 :x:  - 1 

Results for commit e58f9288. ± Comparison against base commit 3e2563dd.

This pull request removes 4004 and adds 3769 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=Austin,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=18424,hostnameExternal=213.95.245.147,portExternalIpv4=39738,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@7289d0b7,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@492f9cb4,memo=6qHvXUuEfd],
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@51f2be11
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@81999dd9
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@89ec4e83
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@5b4a93bb
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@b9e4d2af
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@80c20987
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@93552d4e
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 16:05 github-actions[bot]

Node: HAPI Test (Smart Contract) Results

589 tests   588 :white_check_mark:  1h 11m 6s :stopwatch:  63 suites    0 :zzz:  63 files      1 :x:

For more details on these failures, see this check.

Results for commit e58f9288.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 17:05 github-actions[bot]

using real cryptography in unit tests can lead to very long tests, not sure if this is the best approach to take

lpetrovic05 avatar May 13 '24 13:05 lpetrovic05

using real cryptography in unit tests can lead to very long tests, not sure if this is the best approach to take

This was discussed in our group meeting, and the decision was that it is ok to have real keys generated by this utility given that it is optional and disabled by default.

cody-littley avatar May 13 '24 15:05 cody-littley