hedera-services feat: Write tests for kyc operations

Description:

grantTokenKyc
revokeTokenKyc

Suite	Tests	Signatures
GrantRevokeKycV1SecurityModelSuite	grantRevokeKycSpec	- transaction payer- contract Id- KYC key

Related issue(s): https://github.com/hashgraph/hedera-services/issues/12725 Fixes # https://github.com/hashgraph/hedera-services/issues/12725

May 02 '24 08:05 stefan-stefanooov

Node: HAPI Test (Restart) Results

2 tests 2 :white_check_mark: 7m 52s :stopwatch: 2 suites 0 :zzz: 2 files 0 :x:

Results for commit 4619548f.

:recycle: This comment has been updated with latest results.

May 02 '24 09:05 github-actions[bot]

Node: HAPI Test (Node Death Reconnect) Results

2 tests 2 :white_check_mark: 8m 56s :stopwatch: 2 suites 0 :zzz: 2 files 0 :x:

Results for commit 4619548f.

:recycle: This comment has been updated with latest results.

May 02 '24 09:05 github-actions[bot]

Node: HAPI Test (Token) Results

237 tests 235 :white_check_mark: 21m 58s :stopwatch: 17 suites 2 :zzz: 17 files 0 :x:

Results for commit 4619548f.

:recycle: This comment has been updated with latest results.

May 02 '24 09:05 github-actions[bot]

Node: HAPI Test (Crypto) Results

335 tests 335 :white_check_mark: 40m 42s :stopwatch: 25 suites 0 :zzz: 25 files 0 :x:

Results for commit 4619548f.

:recycle: This comment has been updated with latest results.

May 02 '24 09:05 github-actions[bot]

Node: HAPI Test (Misc) Results

468 tests 457 :white_check_mark: 41m 17s :stopwatch: 77 suites 10 :zzz: 77 files 1 :x:

For more details on these failures, see this check.

Results for commit 4619548f.

:recycle: This comment has been updated with latest results.

May 02 '24 09:05 github-actions[bot]

Node: HAPI Test (Time Consuming) Results

21 tests 21 :white_check_mark: 54m 10s :stopwatch: 3 suites 0 :zzz: 3 files 0 :x:

Results for commit 4619548f.

:recycle: This comment has been updated with latest results.

May 02 '24 10:05 github-actions[bot]

Node: Unit Test Results

2 309 files ±0 2 309 suites ±0 2h 15m 46s :stopwatch: ±0s 118 994 tests ±0 118 927 :white_check_mark: ±0 67 :zzz: ±0 0 :x: ±0 127 555 runs ±0 127 488 :white_check_mark: ±0 67 :zzz: ±0 0 :x: ±0

Results for commit 4619548f. ± Comparison against base commit 919b0d72.

This pull request removes 357 and adds 121 tests. Note that renamed tests count towards both.


  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11] 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395] 
 Some Legal Characters
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [1] AddressBook {
   Address[id=0,nickname=RC2IIV77,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=14242,hostnameExternal=0.99.17.87,portExternalIpv4=14242,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@3bda8856,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@3300893d,memo=OyoEPYP0],
   Address[id=1,nickname=5tvpczSj,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=34850,hostnameExternal=2.1…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@384c3b05, agrKeyPair=java.security.KeyPair@7e566ed5, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [2] AddressBook {
   Address[id=0,nickname=D6DUHuxo,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=41892,hostnameExternal=36.250.176.42,portExternalIpv4=41892,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@25cafb88,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@7524c462,memo=gkxSjQJd],
   Address[id=2,nickname=bHCla7uF,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=59451,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@14ce43fe, agrKeyPair=java.security.KeyPair@3cf27af6, sigCert=  [0]         Version: 3
         SerialNumber: 12482092706667292405
             IssuerDN: CN=s-aaaa
           Start Date: Sat Jan 01 00:00:00 UTC 2000
           Final Date: Fri Jan 01 00:00:00 UTC 2100
            SubjectDN: CN=s-aaaa
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
   Address[id=0,nickname=lthjZ2PS,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=55354,hostnameExternal=244.99.182.227,portExternalIpv4=55354,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@17afb98d,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@54153029,memo=Um8zIwCm],
   Address[id=2,nickname=DiEiqgpC,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=1604,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@2ef6fa77, agrKeyPair=java.security.KeyPair@8c9a2c4, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 3993597839710083868231945175919139090761808006636174301522933223628513549165622405392179927490525437989266705657795380522223992433641724878847443931065713607200936674817049095003247060840820816825608104539722939764219883909214899161…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
   Address[id=0,nickname=mwIfxeGO,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=37952,hostnameExternal=197.119.81.126,portExternalIpv4=37952,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@7a84f06,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@2434f07c,memo=KSRKpf4q],
   Address[id=3,nickname=pA735W9D,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=58498,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@2b28c752, agrKeyPair=java.security.KeyPair@7f256a0c, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
…

:recycle: This comment has been updated with latest results.

May 02 '24 10:05 github-actions[bot]

Node: HAPI Test (Smart Contract) Results

605 tests 604 :white_check_mark: 1h 16m 57s :stopwatch: 63 suites 0 :zzz: 63 files 1 :x:

For more details on these failures, see this check.

Results for commit 4619548f.

:recycle: This comment has been updated with latest results.

May 02 '24 10:05 github-actions[bot]

The changes should be in GrantRevokeKycV1SecurityModelSuite to enable and fix grantRevokeKycSpec() test

I think the new test should be in GrantRevokeKycSuite file. The file name with the v1 tag in it, holds the v1 security model tests. The one no tag, holds the v2 (current) security model tests. This pattern is held in all tests

Do you agree ?

May 07 '24 09:05 stefan-stefanooov

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.22%. Comparing base (474f5ff) to head (4619548). Report is 3 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #13062      +/-   ##
=============================================
+ Coverage      61.75%   67.22%   +5.47%     
- Complexity     31252    36163    +4911     
=============================================
  Files           3446     3700     +254     
  Lines         141289   148961    +7672     
  Branches       14781    15501     +720     
=============================================
+ Hits           87249   100143   +12894     
+ Misses         50155    44492    -5663     
- Partials        3885     4326     +441

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

May 15 '24 11:05 codecov[bot]

hedera-services hedera-services copied to clipboard

feat: Write tests for kyc operations

Node: HAPI Test (Restart) Results

Node: HAPI Test (Node Death Reconnect) Results

Node: HAPI Test (Token) Results

Node: HAPI Test (Crypto) Results

Node: HAPI Test (Misc) Results

Node: HAPI Test (Time Consuming) Results

Node: Unit Test Results

Node: HAPI Test (Smart Contract) Results

Codecov Report

hedera-services
hedera-services copied to clipboard