hedera-services
hedera-services copied to clipboard
feat: HIP-904 Introduce `unlimitedAutoAssociations` feature flag
Description:
Related issue(s):
Fixes #12981
Notes for reviewer:
Checklist
- [ ] Documented (Code comments, README, etc.)
- [ ] Tested (unit, integration, etc.)
Node: HAPI Test (Restart) Results
2 tests 2 :white_check_mark: 8m 3s :stopwatch: 2 suites 0 :zzz: 2 files 0 :x:
Results for commit d9d83146.
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Node Death Reconnect) Results
2 tests 2 :white_check_mark: 10m 8s :stopwatch: 2 suites 0 :zzz: 2 files 0 :x:
Results for commit d9d83146.
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Token) Results
235 tests 233 :white_check_mark: 24m 24s :stopwatch: 17 suites 2 :zzz: 17 files 0 :x:
Results for commit d9d83146.
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Misc) Results
464 tests 454 :white_check_mark: 44m 4s :stopwatch: 77 suites 10 :zzz: 77 files 0 :x:
Results for commit d9d83146.
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Crypto) Results
335 tests 335 :white_check_mark: 39m 49s :stopwatch: 25 suites 0 :zzz: 25 files 0 :x:
Results for commit d9d83146.
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Time Consuming) Results
21 tests 21 :white_check_mark: 53m 48s :stopwatch: 3 suites 0 :zzz: 3 files 0 :x:
Results for commit d9d83146.
:recycle: This comment has been updated with latest results.
Node: Unit Test Results
2 305 files ±0 2 305 suites ±0 4h 25m 8s :stopwatch: + 1h 43m 32s 118 958 tests ±0 118 891 :white_check_mark: ±0 67 :zzz: ±0 0 :x: ±0 127 519 runs ±0 127 452 :white_check_mark: ±0 67 :zzz: ±0 0 :x: ±0
Results for commit d9d83146. ± Comparison against base commit e64faab0.
This pull request removes 4026 and adds 3789 tests. Note that renamed tests count towards both.
IssuerDN: CN=s-aaaa
SubjectDN: CN=s-aaaa
Final Date: Fri Jan 01 00:00:00 UTC 2100
Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
Start Date: Sat Jan 01 00:00:00 UTC 2000
SerialNumber: 12482092706667292405
modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4]
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6]
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@90f80f0f
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@6e1a2a2b
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@2856a881
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@42fe80e9
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@982d7477
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@5f1be691
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@ebb351ed
…
:recycle: This comment has been updated with latest results.
Node: HAPI Test (Smart Contract) Results
592 tests 592 :white_check_mark: 1h 15m 41s :stopwatch: 63 suites 0 :zzz: 63 files 0 :x:
Results for commit d9d83146.
:recycle: This comment has been updated with latest results.
It seems like this PR includes adding the feature flag for both the mono and modularized codebase. Why do we need it in mono?
Codecov Report
Attention: Patch coverage is 50.00000%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 61.74%. Comparing base (
e64faab
) to head (d9d8314
).
Additional details and impacted files
@@ Coverage Diff @@
## 012981-hip-904-unlimited-max-auto-associations #13041 +/- ##
=================================================================================
Coverage 61.73% 61.74%
- Complexity 31227 31231 +4
=================================================================================
Files 3442 3442
Lines 141267 141269 +2
Branches 14778 14780 +2
=================================================================================
+ Hits 87217 87223 +6
+ Misses 50163 50159 -4
Partials 3887 3887
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.