hedera-services icon indicating copy to clipboard operation
hedera-services copied to clipboard

Test `:test-clients:hapiTestSmartContract` has multiple gRPC "possibly CATASTROPHIC" errors

Open david-bakin-sl opened this issue 10 months ago • 3 comments

:test-clients:hapiTestSmartContract shows up in CI as "HAPI Tests (Smart Contract) / Standard", and it's logs report multiple ERRORs from gRPC:

image

These probably indicate the test is sending transactions that are too large ("More than 6144 received") which in turn probably means the test isn't testing what we think it is.

See also #13004 (in case the logged error is changed before you take this issue).

hapiTestSmartContract.log

david-bakin-sl avatar Apr 25 '24 20:04 david-bakin-sl

Closing the issue since it looks like this was fixed in https://github.com/hashgraph/hedera-services/pull/13029 (example run from a recent PR has the check passing).

MiroslavGatsanoga avatar May 09 '24 13:05 MiroslavGatsanoga

PR #13029 fixed the catastrophic failure. This issue is about the tests that caused the failure:

These probably indicate the test is sending transactions that are too large ("More than 6144 received") which in turn probably means the test isn't testing what we think it is.

netopyr avatar May 10 '24 09:05 netopyr

Checking the hapiTestSmartContract.log from above looks like we get a single "More than 6144 received" log which I think is from the cannotCreateTooLargeContract e2e test which is passing. Other errors seem to be due to fuzzy record matching differences but they don't seem related to "More than 6144 received" case. Will try to reproduce locally for the whole :test-clients:hapiTestSmartContract but since it is taking a lot of time it might take a while. @david-bakin-sl do you recall what CI job was failing with those or if there were more than one "More than 6144 received" cases in it?

MiroslavGatsanoga avatar May 10 '24 15:05 MiroslavGatsanoga

Running :test-clients:hapiTestSmartContract for commit 72a15bdaa9 had only cannotCreateTooLargeContract test reporting "More than 6144 received" log.

MiroslavGatsanoga avatar May 13 '24 09:05 MiroslavGatsanoga