test: 04649 - Compare aliases from state with record stream

[kselveliev]

Description: This PR create a new recordStreamValidator for aliases, which checks if account aliases from state are present in the recordStream

This PR modifies: Added StateAccess.java that is responsible for reading the state in HapiTestEngine.java Added AccountAliasValidator.java that is responsible for verifying the account aliases are present in the recordStream Modified HapiTestEngine.java to use the new validator

Related issue(s):

Fixes #4649

Checklist

• [x] Documented (Code comments, README, etc.)
• [x] Tested (unit, integration, etc.)

[github-actions[bot]]

Node: HAPI Test (Restart) Results

2 tests   2 :white_check_mark:  8m 55s :stopwatch: 2 suites  0 :zzz: 2 files    0 :x:

Results for commit b6816141.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 :white_check_mark:  9m 14s :stopwatch: 2 suites  0 :zzz: 2 files    0 :x:

Results for commit b6816141.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Token) Results

237 tests   235 :white_check_mark:  20m 41s :stopwatch:  17 suites    2 :zzz:  17 files      0 :x:

Results for commit b6816141.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Misc) Results

468 tests   457 :white_check_mark:  41m 55s :stopwatch:  77 suites   10 :zzz:  77 files      1 :x:

For more details on these failures, see this check.

Results for commit b6816141.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Crypto) Results

335 tests   335 :white_check_mark:  41m 26s :stopwatch:  25 suites    0 :zzz:  25 files      0 :x:

Results for commit b6816141.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Time Consuming) Results

21 tests   21 :white_check_mark:  53m 58s :stopwatch:  3 suites   0 :zzz:  3 files     0 :x:

Results for commit b6816141.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Smart Contract) Results

604 tests   604 :white_check_mark:  1h 13m 5s :stopwatch:  63 suites    0 :zzz:  63 files      0 :x:

Results for commit b6816141.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: Unit Test Results

  2 309 files  ±0    2 309 suites  ±0   2h 57m 11s :stopwatch: - 23m 30s 118 994 tests ±0  118 927 :white_check_mark: ±0  67 :zzz: ±0  0 :x: ±0  127 555 runs  ±0  127 488 :white_check_mark: ±0  67 :zzz: ±0  0 :x: ±0 

Results for commit b6816141. ± Comparison against base commit 474f5ffe.

This pull request removes 3994 and adds 3757 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@d1cb5031
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@2c09a723
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@10086839
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@6cde17ec
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@4270badc
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@e6ca2677
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@913332ae
…

:recycle: This comment has been updated with latest results.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.75%. Comparing base (474f5ff) to head (b681614). Report is 3 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #12956      +/-   ##
=============================================
- Coverage      61.75%   61.75%   -0.01%     
+ Complexity     31252    31250       -2     
=============================================
  Files           3446     3446              
  Lines         141289   141289              
  Branches       14781    14781              
=============================================
- Hits           87249    87246       -3     
- Misses         50155    50160       +5     
+ Partials        3885     3883       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[netopyr]

I am afraid this needs to be migrated to the new HAPI test framework before it can be merged.

[kselveliev]

I am afraid this needs to be migrated to the new HAPI test framework before it can be merged.

Yes, I will need some time to refactor and adapt the code to work with the new changes.