hedera-services icon indicating copy to clipboard operation
hedera-services copied to clipboard

docs: add a design doc for TokenAirdropTransaction

Open IvanKavaldzhiev opened this issue 10 months ago • 10 comments

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • [ ] Documented (Code comments, README, etc.)
  • [ ] Tested (unit, integration, etc.)

IvanKavaldzhiev avatar Apr 15 '24 12:04 IvanKavaldzhiev

Node: HAPI Test (Restart) Results

3 tests   3 :white_check_mark:  6m 8s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit cae6fe99.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 15 '24 13:04 github-actions[bot]

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  6m 46s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit cae6fe99.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 15 '24 13:04 github-actions[bot]

Node: HAPI Test (Token) Results

 20 files   20 suites   5m 55s :stopwatch: 265 tests 265 :white_check_mark: 0 :zzz: 0 :x: 340 runs  340 :white_check_mark: 0 :zzz: 0 :x:

Results for commit cae6fe99.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 15 '24 13:04 github-actions[bot]

Node: HAPI Test (Misc) Results

 51 files   51 suites   21m 35s :stopwatch: 357 tests 357 :white_check_mark: 0 :zzz: 0 :x: 375 runs  375 :white_check_mark: 0 :zzz: 0 :x:

Results for commit cae6fe99.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 15 '24 14:04 github-actions[bot]

Node: HAPI Test (Crypto) Results

 23 files   23 suites   10m 45s :stopwatch: 352 tests 352 :white_check_mark: 0 :zzz: 0 :x: 358 runs  358 :white_check_mark: 0 :zzz: 0 :x:

Results for commit cae6fe99.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 15 '24 14:04 github-actions[bot]

Node: HAPI Test (Time Consuming) Results

19 tests   19 :white_check_mark:  22m 50s :stopwatch:  4 suites   0 :zzz:  4 files     0 :x:

Results for commit cae6fe99.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 15 '24 14:04 github-actions[bot]

Node: HAPI Test (Smart Contract) Results

 72 files   72 suites   20m 56s :stopwatch: 605 tests 605 :white_check_mark: 0 :zzz: 0 :x: 657 runs  657 :white_check_mark: 0 :zzz: 0 :x:

Results for commit cae6fe99.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 15 '24 14:04 github-actions[bot]

Node: Unit Test Results

  2 354 files    2 354 suites   2h 43m 19s :stopwatch: 120 225 tests 120 154 :white_check_mark: 71 :zzz: 0 :x: 128 788 runs  128 717 :white_check_mark: 71 :zzz: 0 :x:

Results for commit cae6fe99.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 15 '24 15:04 github-actions[bot]

The doc does not mention allowances at all. Please explain how allowances may modify the behavior (where applicable).

netopyr avatar May 09 '24 13:05 netopyr

The doc does not mention allowances at all. Please explain how allowances may modify the behavior (where applicable).

Added more information about allowances and their use case. Also added test cases related to this scenario.

IvanKavaldzhiev avatar May 09 '24 15:05 IvanKavaldzhiev

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.54%. Comparing base (9973fae) to head (bf25695). Report is 36 commits behind head on develop.

:exclamation: Current head bf25695 differs from pull request most recent head cae6fe9

Please upload reports for the commit cae6fe9 to get more accurate results.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #12794      +/-   ##
=============================================
- Coverage      67.58%   67.54%   -0.05%     
- Complexity     36486    36599     +113     
=============================================
  Files           3732     3756      +24     
  Lines         149767   150248     +481     
  Branches       15571    15634      +63     
=============================================
+ Hits          101223   101479     +256     
- Misses         44179    44366     +187     
- Partials        4365     4403      +38     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 04 '24 10:06 codecov[bot]