feat: 12108: Virtual root nodes may be synced in parallel during reconnects

[artemananiev]

Fixes: https://github.com/hashgraph/hedera-services/issues/12108 Signed-off-by: Artem Ananev [email protected]

[github-actions[bot]]

Node: HAPI Test (Restart) Results

7 files  7 suites   8m 27s :stopwatch: 6 tests 6 :white_check_mark: 0 :zzz: 0 :x: 7 runs  7 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9db85e66.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  4m 38s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 9db85e66.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Token) Results

 23 files   23 suites   5m 55s :stopwatch: 282 tests 282 :white_check_mark: 0 :zzz: 0 :x: 365 runs  365 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9db85e66.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Misc) Results

 61 files   61 suites   16m 38s :stopwatch: 316 tests 316 :white_check_mark: 0 :zzz: 0 :x: 410 runs  410 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9db85e66.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Crypto) Results

 32 files   32 suites   11m 45s :stopwatch: 367 tests 367 :white_check_mark: 0 :zzz: 0 :x: 397 runs  397 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9db85e66.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Time Consuming) Results

 4 files   4 suites   22m 53s :stopwatch: 18 tests 18 :white_check_mark: 0 :zzz: 0 :x: 19 runs  19 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9db85e66.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: HAPI Test (Smart Contract) Results

 92 files   92 suites   23m 47s :stopwatch: 660 tests 660 :white_check_mark: 0 :zzz: 0 :x: 872 runs  872 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9db85e66.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Node: Unit Test Results

  1 562 files    1 562 suites   3h 41m 39s :stopwatch: 117 942 tests 117 882 :white_check_mark: 59 :zzz: 1 :x: 126 156 runs  126 096 :white_check_mark: 59 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit 9db85e66.

:recycle: This comment has been updated with latest results.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 66.62831% with 290 lines in your changes missing coverage. Please review.

Project coverage is 57.88%. Comparing base (b0cc342) to head (3640de5).

Files with missing lines	Patch %	Lines
.../internal/reconnect/TopToBottomTraversalOrder.java	0.00%	68 Missing :warning:
...rkle/synchronization/streams/AsyncInputStream.java	55.91%	35 Missing and 6 partials :warning:
...n/merkle/synchronization/LearningSynchronizer.java	63.46%	26 Missing and 12 partials :warning:
...l/reconnect/TwoPhasePessimisticTraversalOrder.java	0.00%	27 Missing :warning:
...n/merkle/synchronization/TeachingSynchronizer.java	68.83%	15 Missing and 9 partials :warning:
...internal/reconnect/ParallelSyncTraversalOrder.java	89.60%	8 Missing and 5 partials :warning:
...kle/synchronization/streams/AsyncOutputStream.java	79.24%	8 Missing and 3 partials :warning:
...l/reconnect/TeacherPullVirtualTreeReceiveTask.java	85.10%	3 Missing and 4 partials :warning:
...internal/reconnect/TeacherPullVirtualTreeView.java	74.07%	2 Missing and 5 partials :warning:
...internal/reconnect/TeacherPushVirtualTreeView.java	0.00%	7 Missing :warning:
... and 19 more

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #12757      +/-   ##
=============================================
+ Coverage      57.85%   57.88%   +0.03%     
- Complexity     19595    19649      +54     
=============================================
  Files           2689     2690       +1     
  Lines          99025    99459     +434     
  Branches       10244    10331      +87     
=============================================
+ Hits           57288    57570     +282     
- Misses         38137    38267     +130     
- Partials        3600     3622      +22     

Files with missing lines	Coverage Δ
...merkle/synchronization/config/ReconnectConfig.java	100.00% <ø> (ø)
...lds/common/merkle/synchronization/task/Lesson.java	85.36% <ø> (ø)
...on/merkle/synchronization/task/TeacherSubtree.java	85.71% <100.00%> (ø)
...kle/synchronization/views/CustomReconnectRoot.java	100.00% <ø> (ø)
...nchronization/views/LearnerPushMerkleTreeView.java	66.66% <100.00%> (ø)
...nchronization/views/TeacherPushMerkleTreeView.java	77.63% <100.00%> (-1.39%)	:arrow_down:
...om/swirlds/virtualmap/config/VirtualMapConfig.java	83.33% <ø> (ø)
...map/internal/reconnect/PullVirtualTreeRequest.java	88.46% <100.00%> (+74.82%)	:arrow_up:
...almap/internal/reconnect/ReconnectNodeRemover.java	94.11% <100.00%> (+0.36%)	:arrow_up:
.../merkle/synchronization/views/LearnerTreeView.java	0.00% <0.00%> (ø)
... and 28 more

... and 15 files with indirect coverage changes

[codacy-production[bot]]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
:white_check_mark: +0.04% (target: -1.00%)	:white_check_mark: 73.42%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (b0cc3426e4cd8548a076ff0ba578d92caa91eb38)	98842	60751	61.46%
Head commit (3640de53669ee40e1172d7c33ce29f7daa526582)	99276 (+434)	61055 (+304)	61.50% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#12757)	869	638	73.42%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}