hedera-services icon indicating copy to clipboard operation
hedera-services copied to clipboard

feat: add design document for hbar allowance/approval

Open lukelee-sl opened this issue 1 year ago • 12 comments

Description: Create a design document that describes adding functionality to smart contracts which allow for granting allowance for hbar to a spender account.

  • [x] Documented (Code comments, README, etc.)
  • [ ] Tested (unit, integration, etc.)

lukelee-sl avatar Feb 27 '24 00:02 lukelee-sl

Node: HAPI Test (Restart) Results

3 tests   3 :white_check_mark:  6m 19s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 3c536abb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 27 '24 00:02 github-actions[bot]

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  6m 50s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 3c536abb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 27 '24 00:02 github-actions[bot]

Node: HAPI Test (Token) Results

 20 files   20 suites   5m 44s :stopwatch: 265 tests 265 :white_check_mark: 0 :zzz: 0 :x: 340 runs  340 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 3c536abb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 27 '24 00:02 github-actions[bot]

Node: HAPI Test (Crypto) Results

 24 files   24 suites   12m 13s :stopwatch: 362 tests 362 :white_check_mark: 0 :zzz: 0 :x: 369 runs  369 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 3c536abb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 27 '24 01:02 github-actions[bot]

Node: E2E Test Results

    1 files      1 suites   25m 25s :stopwatch: 311 tests 311 :heavy_check_mark: 0 :zzz: 0 :x: 333 runs  333 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 978881b4.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 27 '24 01:02 github-actions[bot]

Node: HAPI Test (Misc) Results

 51 files   51 suites   21m 48s :stopwatch: 357 tests 357 :white_check_mark: 0 :zzz: 0 :x: 375 runs  375 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 3c536abb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 27 '24 01:02 github-actions[bot]

Node: HAPI Test (Time Consuming) Results

19 tests   19 :white_check_mark:  23m 13s :stopwatch:  4 suites   0 :zzz:  4 files     0 :x:

Results for commit 3c536abb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 27 '24 01:02 github-actions[bot]

Node: HAPI Test (Smart Contract) Results

 72 files   72 suites   22m 29s :stopwatch: 617 tests 617 :white_check_mark: 0 :zzz: 0 :x: 669 runs  669 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 3c536abb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 27 '24 01:02 github-actions[bot]

Node: Integration Test Results

    5 files      5 suites   1h 6m 24s :stopwatch: 322 tests 322 :heavy_check_mark: 0 :zzz: 0 :x: 333 runs  333 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 978881b4.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 27 '24 01:02 github-actions[bot]

Node: Unit Test Results

  1 551 files    1 551 suites   2h 57m 53s :stopwatch: 108 593 tests 108 534 :white_check_mark: 59 :zzz: 0 :x: 116 887 runs  116 828 :white_check_mark: 59 :zzz: 0 :x:

Results for commit 3c536abb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 27 '24 02:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.05%. Comparing base (abde2b5) to head (1c61b70). Report is 5 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #11759      +/-   ##
=============================================
+ Coverage      61.79%   62.05%   +0.25%     
- Complexity     30620    30731     +111     
=============================================
  Files           3384     3384              
  Lines         138340   138344       +4     
  Branches       14541    14540       -1     
=============================================
+ Hits           85484    85846     +362     
+ Misses         49161    48788     -373     
- Partials        3695     3710      +15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 27 '24 02:02 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.27%. Comparing base (9973fae) to head (3c536ab). Report is 68 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #11759      +/-   ##
=============================================
- Coverage      67.58%   58.27%   -9.31%     
+ Complexity     36486    22080   -14406     
=============================================
  Files           3732     2883     -849     
  Lines         149767   109662   -40105     
  Branches       15571    11159    -4412     
=============================================
- Hits          101223    63910   -37313     
+ Misses         44179    42219    -1960     
+ Partials        4365     3533     -832     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 27 '24 21:03 codecov-commenter