hedera-mirror-node icon indicating copy to clipboard operation
hedera-mirror-node copied to clipboard

Add in equivalence tests for direct calls

Open yiliev0 opened this issue 1 year ago • 3 comments

Description: This PR is still in progress. There are a few assertions that are waiting on bugs to be fixed, so this can be finalised.

Related issue(s):

Fixes #7193

Notes for reviewer:

Checklist

  • [ ] Documented (Code comments, README, etc.)
  • [ ] Tested (unit, integration, etc.)

yiliev0 avatar Feb 26 '24 13:02 yiliev0

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 26 '24 13:02 sonarqubecloud[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.42%. Comparing base (8a400d1) to head (28b4025).

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##             7193-add-in-equivalence-tests-for-system-accounts    #7812      +/-   ##
=======================================================================================
+ Coverage                                                92.27%   92.42%   +0.15%     
+ Complexity                                                6918     4590    -2328     
=======================================================================================
  Files                                                      864      638     -226     
  Lines                                                    28332    20603    -7729     
  Branches                                                  3363     2539     -824     
=======================================================================================
- Hits                                                     26142    19043    -7099     
+ Misses                                                    1426     1034     -392     
+ Partials                                                   764      526     -238     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '24 13:02 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.31%. Comparing base (136fd96) to head (28b4025). Report is 83 commits behind head on 7193-add-in-equivalence-tests-for-system-accounts.

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##             7193-add-in-equivalence-tests-for-system-accounts    #7812      +/-   ##
=======================================================================================
+ Coverage                                                92.27%   92.31%   +0.04%     
- Complexity                                                6918     6998      +80     
=======================================================================================
  Files                                                      864      868       +4     
  Lines                                                    28332    28521     +189     
  Branches                                                  3363     3398      +35     
=======================================================================================
+ Hits                                                     26142    26329     +187     
- Misses                                                    1426     1427       +1     
- Partials                                                   764      765       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 28 '24 08:02 codecov-commenter

Closing the PR as discussed. The tests are no longer needed.

bilyana-gospodinova avatar Aug 07 '24 15:08 bilyana-gospodinova