hedera-mirror-node icon indicating copy to clipboard operation
hedera-mirror-node copied to clipboard

Refactor isValidContractResult in ContractResultServiceImpl

Open konstantinabl opened this issue 2 years ago • 1 comments

Problem

After this fix and this fix in services the isValidContractFunctionResult always returns true. It is a good idea to check the class and this function in particular and possibly remove the check or adjust it.

Solution

  • Enhance the isValidContractFunctionResult check

Alternatives

No response

konstantinabl avatar Feb 16 '24 09:02 konstantinabl

Don't think we need this ticket. It doesn't matter if consensus nodes have improved their logic and will always send a function result. Mirror nodes have to support the full history of transactions so since in the past it was not present it should stay. Unless I'm missing something?

steven-sheehy avatar Feb 16 '24 17:02 steven-sheehy