hedera-json-rpc-relay
hedera-json-rpc-relay copied to clipboard
Failed unit test pipelines may be marked as successful
Description
Because of an issue with istanbuljs/nyc it's possible that failed unit test runs are shown as passing in the CI, for example if a JavaScript heap out of memory
error occurs.
Here's the issue that tracks the bug upstream https://github.com/istanbuljs/nyc/issues/798 The current issue is related to #2300
Steps to reproduce
- Create an example test file
echo "var x = []; while(true) x.push({ a:'123'.repeat(1000000) });" > test.ts
- run
npx nyc ts-mocha --max-old-space-size=16 test.ts
- Check the exit code
echo "Exit code: $?"
Expected exit code is 134
, but the actual is 0
Additional context
No response
Hedera network
other
Version
v0.45.0
Operating system
None