hedera-improvement-proposal icon indicating copy to clipboard operation
hedera-improvement-proposal copied to clipboard

Published 20 hours ago • verified publisher icon hashgraph

Update hip-765.md

Open SimiHunjan opened this issue 10 months ago • 4 comments

  • This HIP did not call out that the adminKey can also sign the TokenUpdateTransaction to modify the metadata field on a NFT collection.

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • [ ] Documented (Code comments, README, etc.)
  • [ ] Tested (unit, integration, etc.)

SimiHunjan avatar Apr 23 '24 14:04 SimiHunjan

Deploy Preview for hedera-hips ready!

Name Link
Latest commit b770a561bde023792a78b1bea32b37e719dca7bf
Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/66292e26a988a10007605a0b
Deploy Preview https://deploy-preview-949--hedera-hips.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 23 '24 14:04 netlify[bot]

cc: @netopyr @Neeharika-Sompalli @ty-swirldslabs

SimiHunjan avatar Apr 23 '24 14:04 SimiHunjan

@mgarbs not sure who needs to be assigned to review this from a required reviewer

SimiHunjan avatar Apr 23 '24 20:04 SimiHunjan

@mgarbs not sure who needs to be assigned to review this from a required reviewer

Hi Simi! Could you resolve these two validation errors? https://github.com/hashgraph/hedera-improvement-proposal/actions/runs/8802584923/job/24158660356?pr=949#:~:text=21-,Error%3A%20updated%20date%20doesnt%20match%20current%20date%20in%20header%2C%20add%20current,at%20processTicksAndRejections%20(internal/process/task_queues.js%3A97%3A5),-28

Other than that looks great!

mgarbs avatar Apr 24 '24 12:04 mgarbs