hashcat-legacy icon indicating copy to clipboard operation
hashcat-legacy copied to clipboard

hashcat-cli.c: fix build against musl libc

Open rofl0r opened this issue 9 years ago • 5 comments

GLIBC's termio.h is just an empty file with 2 include directives:

#include <termios.h> #include <sys/ioctl.h>

and a comment that says that it is obsolete and you should use termios.h and struct termios instead - exactly what musl libc does.

since the obsolete interface was replaced with termios by POSIX, musl only implements the standardized interface.

rofl0r avatar Nov 25 '16 23:11 rofl0r

updated to use tcgetattr/tcsetattr instead of ioctl syscalls and merged the BSD/OSX/LINUX code together..

rofl0r avatar Nov 26 '16 09:11 rofl0r

we probably could even get rid of all ifdefs apart from

#ifdef WINDOWS
... nonportable code here
#else
posix code here
#done

that way the code works by default on all platforms conforming to POSIX, even those that are not hardcoded in yet.

rofl0r avatar Nov 26 '16 09:11 rofl0r

hello @jsteube : is there something missing in this PR (i would be glad to add that then) or is this repo already abandoned ? this repo here seems to be better suited for my usecase, since it doesn't depend on openCL and i would be glad if it compiled OOTB.

rofl0r avatar Nov 29 '16 20:11 rofl0r

I'm sorry, it's dead. Note that cracking, depending on hash-mode, is up to 800% faster even on CPU only. There's almost no reason to continue using hashcat-legacy. OTOH, it would be really cool to know if hashcat runs on musl libc and if not, to patch it so that it works.

On 29.11.2016 21:26, rofl0r wrote:

hello @jsteube https://github.com/jsteube : is there something missing in this PR (i would be glad to add that then) or is this repo already abandoned ? this repo here seems to be better suited for my usecase, since it doesn't depend on openCL and i would be glad if it compiled OOTB.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hashcat/hashcat-legacy/pull/71#issuecomment-263688465, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ83OUrUGgO8S-4rV-PXuws5zmNBx2Ysks5rDIp_gaJpZM4K8v3G.

jsteube avatar Nov 29 '16 20:11 jsteube

looks as if all openCL implementations apart from pocl and mesa are closed-source and as such not musl-compatible (the closed-source ones are all linked against GLIBC). mesa is AMD-GPU only, and pocl in beta stadium, so it seems we have to stick to "legacy" for the time being.

rofl0r avatar Dec 01 '16 22:12 rofl0r