gitops
gitops copied to clipboard
hashbang
Github commit status integration
github apps need an extra dance. https://github.com/argoproj-labs/argocd-notifications/issues/99
@daurnimator I'd like to work on this, could you rebase and re-encrypt argocd/argocd-notifications/secret.enc.yaml ?
@daurnimator Thanks! Looks like you even updated it to use the upstream support instead of a custom 'cron' job and ruby script. <3
If I follow correctly, argocd-notifications-cm.patch.yml is applied to applicationset-generator.yml, and so the settings under template will apply to all applications deployed on argocd?
TBH this seems good to me. What's holding it as a work-in-progress? We may want to have argo run dry-runs on our PR branches, but I can try and make a follow-up PR later.
TBH this seems good to me. What's holding it as a work-in-progress?
Completely untested. Though it might work as-is.
TBH this seems good to me. What's holding it as a work-in-progress?
Completely untested. Though it might work as-is.
OK. Do we (currently) have a way to test it other than deploying it?
If not, I'd be fine with deploying as-is (and being sad we are testing in production)
OK. Do we (currently) have a way to test it other than deploying it?
not really; other than spinning up a local cluster and trying there.... but that then needs it's whole own overlay with it's own github app etc. Too much to bother with IMO.
If not, I'd be fine with deploying as-is (and being sad we are testing in production)
Sure. I'll take the PR out of draft