gitops icon indicating copy to clipboard operation
gitops copied to clipboard

Add Infro PR Checks?

Open colethienes opened this issue 1 year ago • 4 comments

I noticed that this repo uses Argo CD, and I thought I’d let you know that I recently released a Github app called Infro that several companies use internally that allows Argo CD users to preview Kubernetes changes in Github pull requests before they merge. I’m providing it for free to open source projects (here’s an example in the wild). Here’s a setup guide with links to documentation. It’s in early stages, so I’m sure there will be warts. All feedback is welcome!

colethienes avatar Feb 27 '24 22:02 colethienes

@colethienes interesting. I wanted to give it a try but I don't agree to the permissions

image

"Act on your behalf" is too broad and I wouldn't ever agree to that.

daurnimator avatar Feb 28 '24 00:02 daurnimator

Got it. If you don't want to give a third party permissions, I think I will most likely open source. If I do, would it be most useful to you to open source a Github action or Github app?

colethienes avatar Feb 29 '24 09:02 colethienes

I open sourced a version as a GitHub action here! https://github.com/infro-io/infro-core?tab=readme-ov-file#as-a-github-action

colethienes avatar Mar 20 '24 21:03 colethienes

I open sourced a version as a GitHub action here! https://github.com/infro-io/infro-core?tab=readme-ov-file#as-a-github-action

I had a quick look and saw https://github.com/infro-io/comment-diffs-action/issues/1 as a problem

daurnimator avatar Mar 21 '24 05:03 daurnimator

@colethienes added.

In https://github.com/hashbang/gitops/pull/251#issuecomment-2367456229 I can see it shows diffs from live cluster to repo. The live cluster might not currently be at the previous HEAD. This can make the PR comment pretty misleading

daurnimator avatar Sep 23 '24 07:09 daurnimator