hasjob icon indicating copy to clipboard operation
hasjob copied to clipboard

switched dangerous default arguments to None

Open shayneofficer opened this issue 3 years ago • 3 comments

Per the code sniff here using mutable lists/dictionaries as default arguments is a bug risk.

shayneofficer avatar Oct 07 '21 16:10 shayneofficer

Hi, I was on holiday and missed this. I’m not sure why you’ve closed the PR. In any case, I’ve implemented similar fixes in #637.

jace avatar Oct 21 '21 11:10 jace

Hi @jace ! no worries, thanks for the response 😄 I closed it since one of the build pipeline checks said I introduced a new bug I think - happy to re-open if you think this change is valuable though!

shayneofficer avatar Oct 21 '21 11:10 shayneofficer

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 16 '22 15:05 CLAassistant