open-bus-map-search
open-bus-map-search copied to clipboard
hasadna
add more details about a line in the line profile page
extract data from json, and show it in a visually appealing way
- line origin / destination
- bus company logo
- etc
@TuvalSimha let us know where are you standing and if you need any help! If you're still on this issue, please let us know and you'll be re-assigned Thanks!
is it still relevant? i need a bit more information. it looks like the data from the JSON is already in use. (logo, line origin / destination)
So, do I need to use another API call to show the table with the bus schedule?
@dorinzrihen Hi Dorin, thanks for raising this question! Actually, I don't really get the idea of that table. The schedule of the bus can (theoretically) change every day - so why bother with a table? I do believe that having a list of stations can be nice, but the page looks way better compared to the screenshot made when this issue was originally opened thanks to the great work of many volunteers. Actually, I don't see the planned route - do we have a bug? Anyway I guess this issue is not very relevant - perhaps it would be better to move on and make similar page for operators (see #458).
this api will get the stops list, if we want to show something fancy :) https://open-bus-stride-api.hasadna.org.il/docs#/gtfs/list__gtfs_stops_list_get
@NoamGaash Could it be that this issue has already been resolved? I checked several lines, and each time the details (logo, origin, destination) appeared. Attached is a sample image.
@Tami-Co Oh, my bad. Seems you're right, the page is almost complete. Adding the list of stops can be a nice addition, but I guess it could be opened as a separate issue - anyway, would you like to try handling this task? Also, seems like the map doesn't render nicely in the screenshot you've attached. Is this a bug? It seems like it is
@NoamGaash I can take on the task of adding the stops. Regarding the map, it was a one-time issue on my side. I checked, and it's fine now. I'm attaching a picture.
Cool, glad to hear that! If you will manage to reproduce the issue in the future, opening a new issue about it with clear steps to reproduce the issue could be very helpful
@NoamGaash
Regarding the task of adding the station list, have you already opened an issue about this?
Also, I would appreciate more details on what the task should include.
thanks!
@Tami-Co I don't think such issue was opened, feel free to contribute an issue. I'm not sure what this list should include, for start we can show a plain html list of all stations, but the sky is the limit and any functionality can be added (for example, hovering a station name can highlight the same station on the map)