[BUG] Interactive ISO Install NTP-Servers Don't Remove Duplicates W/ Config URL

[irishgordo]

Describe the bug If setting up Harvester via Interactive ISO Installation, when the panel asks for NTP servers, a user inputs one. When prompeted for a configuration URL that holds the YAML like:

scheme_version: 1
os:
  ntp_servers:
    - 192.168.120.29
  dns_nameservers:
    - 192.168.120.121
install:
  wipeDisks: true
system_settings:
  backup-target: '{"type":"s3","endpoint":"http://192.168.120.20:9000","accessKeyId":"myuserserviceaccount","secretAccessKey":"myuserserviceaccountsecret","bucketName":"harvester-vm-backup-bucket","bucketRegion":"sample-test-1","cert":"","virtualHostedStyle":false}'
  ui-source: auto

If the user entered 192.168.120.29 during the Interactive ISO Install Panel prompt. Harvester will not recognize that the NTP Servers are duplicates. So when install finishes there will be two of the same in the Harvester -> Settings.

To Reproduce Steps to reproduce the behavior:

1. Create a configuration somewhere hosted
2. Install Harvester, input the same NTP Server that you use in the Configuration
3. Let install finish, check Harvester->Settings

Expected behavior Duplicates to be ignored / some sort of merging logic when bringing in a Config URL during Interactive ISO Install time.

Workaround

• manually clean up duplicates after install

Environment

• Harvester ISO version: v1.3.1 , v1.3.2-rc2
• Underlying Infrastructure: bare-metal HP DL160s

Additional context

[irishgordo]

For more context we protect against duplicates on the front-end:

There are duplicate NTP server configurations.

It's just there's no logic for duplicate checking at install time either with:

• interactive iso install & configuration url provided
• pxe based install and configuration provided

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions[bot]]

This issue was closed because it has been stalled for 5 days with no activity.