harvester-ui icon indicating copy to clipboard operation
harvester-ui copied to clipboard

Network text changes & "Type" question

Open tfiduccia opened this issue 4 years ago • 2 comments

Text Changes:

  • [x] On Network list page : If the Network NIC isn't moved into Edit host, then the warning message should change to - "You must configure a network in Settings before you can create a new network." have "Settings" be a link to the network settings.

  • [x] If the physical NIC is invalid in settings: on Network list page: CHange the text to say "Physical NIC value in Setting is invalid". Have "Settings" be a link to the network settings.

  • [ ] In Network setting if you enter a wrong NIC, the message should say '[nic field info] is not a valid physical NIC."

Questions in Settings & Create Network:

  1. I noticed in Network Setting and Create Network, in the Type drop-down you can only select VLAN. If that is the only option it probably shouldn't be a drop-down (or a field at all)

  2. If you can have more than one "Type", then the behavior should be: If only 1, show it as a regular read-only field (not a drop-down). Once there is more than 1, it should change to active and a drop-down field.

tfiduccia avatar Nov 17 '20 18:11 tfiduccia

@guangbochen case 2, 3 needs backend enhancement.

WuJun2016 avatar Nov 23 '20 09:11 WuJun2016

link to issue https://github.com/rancher/harvester-network-controller/issues/16

guangbochen avatar Dec 04 '20 03:12 guangbochen