dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

feat: Introduce Per-Project Ignore of npmrc

Open irishgordo opened this issue 1 year ago • 0 comments

Summary

Allows project level .gitignore of .npmrc - enabling more flexibility for contributors that may already have a something like a global level .npmrc and want more granular control within the harvester/dashboard project.

X-Ref: npmrc from npm Docs X-Ref: npm config from npm Docs

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • N/A
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • N/A, not needed, just moving forward could leverage
  • Are backend engineers aware of UI changes?
    • N/A, no UI changes

Fixes #

  • introduce .gitignore project-level .npmrc file ignore

Occurred changes and/or fixed issues

  • .gitignore expands to now include project-level .npmrc ignore

Technical notes summary

allows for contributors to have a project-level based .npmrc file as they work to contribute to the harvester/dashboard project without worry that that .npmrc file will be picked up during git commit of changes

Areas or cases that should be tested

  • mostly N/A:
    • could validate that when a .npmrc added at project level that no changes get picked up with something like:
  ╭─mike at suse-workstation-team-harvester in ~/Projects/temp-dashboard/dashboard on feat/ignore-npmrc-file✔
╰─± touch .npmrc
╭─mike at suse-workstation-team-harvester in ~/Projects/temp-dashboard/dashboard on feat/ignore-npmrc-file✔
╰─± which zsh
/usr/bin/zsh
╭─mike at suse-workstation-team-harvester in ~/Projects/temp-dashboard/dashboard on feat/ignore-npmrc-file✔
╰─± echo "script-shell=/usr/bin/zsh" > .npmrc
╭─mike at suse-workstation-team-harvester in ~/Projects/temp-dashboard/dashboard on feat/ignore-npmrc-file✔
╰─± cat .npmrc
script-shell=/usr/bin/zsh
╭─mike at suse-workstation-team-harvester in ~/Projects/temp-dashboard/dashboard on feat/ignore-npmrc-file✔
╰─± git status
On branch feat/ignore-npmrc-file
nothing to commit, working tree clean

Areas which could experience regressions

  • N/A, since we're not committing any .npmrc file to source currently there should be no impact to any pipelines

Screenshot/Video

  • N/A

irishgordo avatar Nov 28 '23 19:11 irishgordo