dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

vm-import-controller Change StorageClassName to StorageClass

Open abonillabeeche opened this issue 9 months ago • 0 comments

Change StorageClassName to StorageClass to match the chart

Summary

The UI asks for a StorageClass but we pass a StorageClassName, which has no match. Therefore the chart uses the default StorageClass.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • [ ] Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • [ ] Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • [ ] Yes, the backend owner is:

Fixes #

While creating a custom migration scenario, we observed the preferred StorageClass wasn't in use. After looking into it, Gaurav pointed out the incorrect syntax was used.

Areas or cases that should be tested

Upgrade from 1.2.1, then edit and Save the AddOn.

Areas which could experience regressions

This change, when Saved, will create another PVC and delete the old one in the correct StorageClass as orignally defined vs the default SC. It could cause disk utilization issues if the user expected them somewhere else (which was originally wrong)

abonillabeeche avatar May 02 '24 00:05 abonillabeeche