Close the "Add review" dialog by clicking the Top Right side "X", the dialog cannot be displayed again.

[l00193629]

Redmine Version: 3.4.5. Using Chrome to test.

Open the "Add review" dialog, and then close it by clicking the "X", when I try to add review comment again, the dialog will be not opened. But if I close the dialog by clicking the "Cancel" button, everything is working.

So I changed to code in code_review.js as below:

function formPopup(x, y){ //@see http://docs.jquery.com/UI/Effects/Scale var win = $('#review-form-frame').dialog({ show: {effect:'scale', direction: 'both'},// ? 'top-left' // position: [x, y + 5], width:640, zIndex: topZindex, title: add_form_title, close: function(event, ui) { // rewrite the close event of jquery hideForm(); } }); // win.getContent().style.background = "#ffffff"; if (review_form_dialog != null) { review_form_dialog.dialog('destroy'); review_form_dialog = null; } review_form_dialog = win; topZindex += 10; return false; }

Can you help to check the issue and get formal release?

One more issue, I am using CKEditor plugin also, when I open the add review dialog second time, the CKEditor cannot be edited.

Thank you very much.

[haru]

Thank you for your report.

But I can't reproduce this issue. I tried to use Chrome with Windows 10 and MacOS High Sierra. And Both works fine.