Olaf Hartig

Results 33 comments of Olaf Hartig

@afs We have discussed internally whether we need an CCLA and came to the decision that this is not needed in this case. It is sufficient that there are commits...

> [@rvesse] So squashing into some sensible number of commits (and I'll leave that to your judgement) where each commit represents some coherent chunk of development of this feature would...

> > [@SimonBin] Precisely because the GeoSPARQL 1.1/1.2 aggregate functions would also greatly benefit from being able to ORDER BY and UNFOLD in certain ways, I believe we should take...

> [@afs] Could you please create an issue at https://github.com/apache/jena/issues for this. Done: #2518 > [@afs] While there are a lot of files, it looks to me like the majority...

@afs I am done with rebasing now. `mvn clean install` still runs without problems, and I can also run our [SPARQL CDTs test suite](https://github.com/awslabs/SPARQL-CDTs/tree/main/tests).

> [@SimonBin] I have some high-level comments > > * related prior art from Stardog: https://www.stardog.com/blog/extending-the-solution Thanks for the pointer. I knew that Stardog had something similar, but I wasn't...

@afs apologies for the delay; after I came back from traveling, my university responsibilities required all my time. > I haven't managed to do a clean "git rebase" against the...

@afs I have now copied [the manifest-driven tests from the SPARQL CDTs repo](https://github.com/awslabs/SPARQL-CDTs/tree/main/tests) into this PR and integrated them to run automatically as unit tests (see commit https://github.com/apache/jena/pull/2501/commits/25494354c61e2999747b297b99d86e8bfca1d5cd). Of course,...

Thanks Andy! Let me know if you need my help with anything. There is one thing remaining from the discussion above: [You mentioned the following performance-related concerns](https://github.com/apache/jena/pull/2501#issuecomment-2156169828) regarding the `CDTAwareParserProfile`...

> For now, a separate CDTAwareParserProfile is better. This is an internal issue so it can change later. Okay. > The next step to make the branch on apache/jena then...