gnome-gesture-improvements icon indicating copy to clipboard operation
gnome-gesture-improvements copied to clipboard

[Draft]: New UI and 4 finger App navigation vertical motion gestures

Open adhadse opened this issue 2 years ago • 0 comments

Hey @harshadgavali, This is a draft PR and requires your help (and possible review). Follow up from PR #98.

Currently, the changes I have made require the user to select Extension (functionality) the user intends to use. So something like (visualize in your mind) or check ui file for gestures: Swipe Gestures: Three Finger gestures:

  • 3 finger Left/Right Swipe : dropdown menu
  • 3 finger Top/Down Swipe: dropdown menu
  • Pinch: dropdown menu

Four Finger gestures:

  • 4 finger Left/Right Swipe : dropdown menu
  • 4 finger Top/Down Swipe: dropdown menu
  • Pinch: dropdown menu

Apart from that I also moved swipe gestures src code files into their dedicated folder resonating with pinch gesture and tracker files.

Main Modification are done to extension.ts creating a new function that set the sub-extension and gesture using a new Class SwipeGestureToExtensionMapper given the gesture info (n_fingers, horizontal/vertical & natural scroll in case of app navigation). This class makes sure that two gestures don't get mapped to the same extension.

The problem is, here on this line the extension can be undefined which we can't push to _extensions. So that means if condition in get_extension function's switch condition, we need to generate error and throw Dialog box informing user two gestures can't be set for one functionality OR If you have some better idea.

OR we can dynamically update the model for dropdown menus as the options get selected

adhadse avatar Jul 02 '22 16:07 adhadse