links icon indicating copy to clipboard operation
links copied to clipboard

Published 20 hours ago • verified publisher icon harsh98trivedi

Request - Dockerfile

Open undaunt opened this issue 3 years ago • 2 comments

Hello,

Your project demo looks fantastic - I think it's a much prettier layout than https://github.com/techno-tim/littlelink-server. I was wondering how difficult it would be to package it up for a docker deployment?

Thanks for any thoughts!

undaunt avatar Feb 02 '22 19:02 undaunt

I don't have much experience with Docker, so I believe it'll be quite difficult. However, the project is open-source so I won't mind if someone helps me in packaging it for docker deployment.

harsh98trivedi avatar Feb 06 '22 22:02 harsh98trivedi

I'll start digging into it. I don't have much experience creating my own Dockerfile but I've modified others previously.

undaunt avatar Feb 08 '22 06:02 undaunt

I just created a PR that adds support for Docker, hopefully that's what you were looking for @undaunt

NelsonDane avatar Sep 08 '22 04:09 NelsonDane

Thanks, @NelsonDane! 🙌

harsh98trivedi avatar Sep 08 '22 06:09 harsh98trivedi

This is great, thanks!

Is it possible to have the image regenerate on build, in a way? What I mean is, could we create a bind mount volume requirement pointing to the config file so instead of having to manually rebuild and run on change, we could just restart the container and it would parse the latest version of _config.yml?

undaunt avatar Sep 24 '22 02:09 undaunt

@NelsonDane figured out how to fix this and will surely push the changes soon. He is also planning to host this over DockerHub and sync it with this repository. I hope you'll surely get a fix soon @undaunt

harsh98trivedi avatar Sep 26 '22 15:09 harsh98trivedi

Hey @harsh98trivedi and or @NelsonDane were you able to pull this into the main repo?

Thanks!

undaunt avatar Apr 16 '23 03:04 undaunt

I completely forgot about this and got busy with school/life, but I just put a PR in that should fix this issue @undaunt

NelsonDane avatar Apr 18 '23 23:04 NelsonDane