rescripts icon indicating copy to clipboard operation
rescripts copied to clipboard

Show error output for rescript config errors

Open Coteh opened this issue 4 years ago • 3 comments

Hi, another quick question and feel free to close if there's something I missed when reading the documentation.

I created a .rescriptsrc.js file as a custom rescript that modifies webpack config and put this file in my project root. I noticed that when I run into any JS error, it does not display it at all, instead it shows:

You're likely seeing this bug because you haven't defined a root rescript or your root rescript contains a syntactical error. If you're certain of otherwise, please file an issue.

I took a quick skim of loader.js and I was just wondering how difficult/feasible it would be to emit errors here, or if there's another way to do it that I don't of yet. If there's something that can be implemented, I'd be interested to help as well. Thanks for reading.

Coteh avatar Sep 03 '20 02:09 Coteh

Good question! It's feasible (emitting the parse error). Would love a PR! :)

harrysolovay avatar Nov 04 '20 20:11 harrysolovay

Hi @harrysolovay I have started working on this, and I have a question. If .rescriptsrc is provided, it attempts to parse JSON first then attempts to load it as a node module. In the case that there's both a JSON error and a JS error in the file, which should be prioritized? Currently it will emit both types of errors.

Also, can you assign me to this issue since I started working on it. Thanks.

Coteh avatar Nov 09 '20 02:11 Coteh

Will this be merged/released soon? @harrysolovay

trickpattyFH20 avatar Jan 21 '21 03:01 trickpattyFH20