harrisoncramer
Draft: Fix: Go Gitlab Project Has Moved
This required changing Go to 1.23, unless I'm mistaken, which will make this an unfortunate breaking change for downstream users. To fix, users will have to update their local Go versions to 1.23.4, as the plugin requires this local version of Go in order to compile.
It's worth looking at shipping precompiled versions of the plugins moving forward to avoid this for end-users in the future.
Fixes #447.
Note: This is a #MAJOR breaking change, that will require users to update their versions of Go locally to latest (1.23.4)
I was receiving 500 errors when trying to add comments to an MR, and changing to this branch fixed it.
I've been testing client-go because of other features and it turns out, that there will be some more work to be done when switching from xanzy/go-gitlab, e.g., the ListProjectMergeRequests now returns BasicMergeRequests, rather than MergeRequests.
Hi @harrisoncramer. I'd like to ask about your plans with this MR and with the plugin in general. I would appreciate if the xanzy/go-gitlab library could finally be replaced as it would unblock some issues (e.g., #478, #182, and possibly #386). Also, I'd like to add some other functionality and I'm not sure if I should open PRs here or just work on my fork.
@jakubbortlik The problem with updating to the latest Go version is that clients of the plugin would have to install later versions of Go, because that's used to compile the application locally. I'd rather not ship such a breaking change, or at least if we do, then make sure we do it carefully.
Honestly, I'm rarely using Gitlab these days as my new employer doesn't use it, so if you're interested in taking on a PR that updates the Go version in a graceful way then go for it, but I'll probably only minimally contribute from here forward.
I'll work on this migration shortly. We'll probably have to have a migration tool such that when someone upgrades, it prompts them to install the latest version of Go or something. Will think on it.