gitlab.nvim icon indicating copy to clipboard operation
gitlab.nvim copied to clipboard

Show more details about approvals in MR Summary

Open jakubbortlik opened this issue 1 year ago • 3 comments

Feature Description

One thing that is missing in gitlab.nvim and for which I frequently visit Gitlab online is a more detailed listing of approvals of a MR. In some projects we have rules like two approvals for certain files/filetypes and gitlab.nvim only shows not_approved in case there is already one approval.

I've just realized, alternatively I could use the glab tool for listing this from inside Neovim:

:!glab mr approvers

Listing merge request !454 eligible approvers:
Approval rules overwritten.
Rule "All Members" sufficient approvals (1/1 required):
Jakub Bortlík   jakub.bortlik   👍

Rule "*.py" insufficient approvals (1/2 required):
Some Guy   some.guy   -
Jakub Bortlík   jakub.bortlik   👍

It would be nice if this information was in some form available in the MR summary in gitlab.nvim.

jakubbortlik avatar Dec 10 '24 09:12 jakubbortlik

Hey Jakub, this is an interesting idea, thanks for sharing -- you have a few other open issues and feature requests. Do you mind prioritizing those first?

harrisoncramer avatar Dec 11 '24 19:12 harrisoncramer

Hi Harrison, yeah this would be nice to have but since there is a workaround with glab mr approvers it's low priority. I'd really appreciate if #425 could be fixed - currently I just don't bulk-publish drafts because I don't want to deal with the possible mess it can create.

jakubbortlik avatar Dec 11 '24 22:12 jakubbortlik

For anybody who'd like to take a look at this: Getting the approvals from Gitlab is possible with GetConfiguration. This is a link to the new fork of the library but in the original one by xanzy it can be found in practically the same place.

jakubbortlik avatar Jun 11 '25 08:06 jakubbortlik