browse icon indicating copy to clipboard operation
browse copied to clipboard

2.12 support

Open cvogt opened this issue 7 years ago • 4 comments

@sethtisue implemented support for 2.12.0 https://github.com/cvogt/browse/tree/topic/2.12-compat

I added support for 2.12.1 https://github.com/cvogt/browse/tree/topic/2.12.1-compat

Looks like @paulp had done this, too, but I can't find the source code. The binaries are here: https://bintray.com/paulp/maven/sxr/1.0.2#files/org/improving/sxr_2.12/1.0.2

@paulp Since this is a compiler plugin, it should be released with scala minor versions in the artifactId. The plugin is definitely binary incompatible between 2.12.0 and 2.12.1 as you can see from my patch here: https://github.com/cvogt/browse/commit/67261cdbcc27a1e044d7b280b2db0a02ba27add5 (the previously overridden method became final in 2.12.1 and the new one didn't exist in 2.12.0)

cvogt avatar Apr 08 '17 21:04 cvogt

cc @dwijnand @retronym @eed3si9n

cvogt avatar Apr 08 '17 21:04 cvogt

cc @OlegYch @lrytz (just cc-ing some people who worked on this or sbt, so we don't replicate each others work)

cvogt avatar Apr 08 '17 21:04 cvogt

There's an unmaintained fork called sbt/sxr for sbt's use, and Paul forked that as https://github.com/paulp/sxr.

eed3si9n avatar Apr 08 '17 22:04 eed3si9n

never mind there's already a conversation going on in https://github.com/harrah/browse/issues/26

eed3si9n avatar Apr 08 '17 22:04 eed3si9n