img with base64 encoded src does not display.

[gahoo]

Current Behavior

img with base64 encoded src was not included.

Expected Behavior

img with base64 encoded src should also be included.

Steps to reproduce

Html with base64 img src. URL: https://bioconductor.org/packages/3.8/workflows/vignettes/simpleSingleCell/inst/doc/xtra-3-var.html

System Information

MacOS 10.14.3, Firefox 66.0.3 Addon

---

Great service, works great most of the time. Base64 encode src is not commonly used else where. But in rmarkdown formated R package documents base64 encoded img src is widely adpoted.

[wrobbins]

Hey @gahoo I just came across this issue. It appears that @haroldtreen intentionally discards inline images. If I can get some history on why, and if this can be removed, I can give this feature a shot.

[haroldtreen]

Ah - I feel like my notifications for issues are busted. Thanks for catching this @wrobbins !

I can't remember why I started removing them 🤔. My suspicion is that they were perhaps poorly supported by epub? Or maybe I came across a site that resulted in a broken epub because of a poorly formatted inline image?

Might be possible to get it to work, but might also need to add some logic for validating that it's a png or some other epub friendly format... could also try removing it and see if this is fixed or if a wave of broken epubs appear 😅.

[wrobbins]

I'll see what I can do, should help with re-familiarization of the codebase :)