ansible-gitlab-runner icon indicating copy to clipboard operation
ansible-gitlab-runner copied to clipboard

Published 20 hours ago • verified publisher icon haroldb

Fix broken install on ubuntu

Open skolsuper opened this issue 9 years ago • 4 comments
trafficstars

I can confirm that @sloev's fix in issue #3 works for me on ubuntu 14.04 so I am making a PR out of it. However, I have not tested this with any other distros.

skolsuper avatar Jun 03 '16 09:06 skolsuper

This should work fine on the other distros. @haroldb Any possibility of merging this?

clessg avatar Dec 14 '16 03:12 clessg

I do see a problem with this. It isn't idempotent. The curl task should not have to run over and over if the runner is already installed.

scolson avatar Dec 19 '16 23:12 scolson

I actually agree, and don't think the curl somescript.sh | sudo bash anti-pattern is great either even with https, but will leave the PR open for visibility, since at least one person has found it useful.

skolsuper avatar Dec 19 '16 23:12 skolsuper

Take a look at one of the other forks: https://github.com/DBLaci/ansible-gitlab-runner

They split the repo step out in to 14.04 and 16.04 when blocks. While not quite as flexible for the future, in the interests of visibility on this issue, it is worth pointing out.

scolson avatar Dec 20 '16 13:12 scolson