gitness icon indicating copy to clipboard operation
gitness copied to clipboard

Override drone build restart parameters

Open asosso opened this issue 2 years ago • 3 comments

drone build restart never override the custom parameters set by cli if they are already present in the build:

I.E.

$ drone build restart org/myrepo -p DOWNSTREAM_IMAGE_VER=test1 1
Number: 2
Status: pending
Event: push
[...]

In this case it works: DOWNSTREAM_IMAGE_VER=test1

$ drone build restart org/myrepo -p DOWNSTREAM_IMAGE_VER=test2 2
Number: 3
Status: pending
Event: push
[...]

In this case the variable test2 is ignored: DOWNSTREAM_IMAGE_VER=test1

More detail about the issue: https://discourse.drone.io/t/issue-with-params-using-downstream-plugin/10418

asosso avatar Jan 14 '22 18:01 asosso

Hi @asosso

Can you please add a unit test for this?

Cheers, Eoin

eoinmcafee00 avatar Jan 18 '22 11:01 eoinmcafee00

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 19 '22 06:01 CLAassistant

What is the state of this PR? Can we expect a merge? We are also affected by this and could deliver an example where the downstream trigger does not behaves as expected.

{"version":"2.11.1"}

leandrolerena avatar Mar 18 '22 15:03 leandrolerena

Any updates on this?

yegor-usoltsev avatar May 16 '23 22:05 yegor-usoltsev

This PR has been automatically closed due to inactivity.

bot2-harness avatar Dec 19 '23 19:12 bot2-harness