harmony icon indicating copy to clipboard operation
harmony copied to clipboard

feat(commands): add regular expression prefixes

Open cubedhuang opened this issue 2 years ago • 1 comments

About

This adds regex prefixes to the CommandClient and adds one in /test/class.ts. It addresses #306.

Status

  • [x] These changes have been tested against Discord API or do not contain API change.
  • [ ] This PR includes only documentation changes, no code changes.
  • [ ] This PR introduces some Breaking changes.

cubedhuang avatar Jul 21 '22 18:07 cubedhuang

lgtm, fix the lint issue and i think we can merge this

i think this is an eslint issue because .startsWith should always return a boolean. the issue might be that the eslint version is using an old version of typescript which doesn't have better type guards, not sure how to fix

cubedhuang avatar Jul 30 '22 18:07 cubedhuang

merging for now, I think I can fix the lint error

Helloyunho avatar Aug 26 '22 13:08 Helloyunho