bounties icon indicating copy to clipboard operation
bounties copied to clipboard

Implementation of WalletConnect

Open Ssu-OwO opened this issue 3 years ago • 29 comments

Description

Implementation of WalletConnect on Staking Dashboard

Context

We've noticed that on Harmony's staking platform there are only Ledger Nano, Math, and Harmony wallets currently available - given WalletConnect being a popular protocol, we wonder if it's possible to implement WalletConnect as one of the supported methods to sign the delegation.

The WalletConnect is a protocol that can be used to sign transactions using mobile wallets that support walletconnect protocol.

Reference

https://docs.walletconnect.org/v/2.0/

Acceptance Criteria

  • [ ] add support of wallet connect to the current staking dashboard without breaking existing functions
  • [ ] PRs submit to harmony staking dashboard repo and work with Harmony team to merge the PRs
  • [ ] recorded video to demonstrate the function of a working walletconnect support on all actions of staking dashboard
  • [ ] test with a few mobile wallets with walletconnect support such as TrustWallet

Reward

USD $10,000 equivalent of ONE token

Ssu-OwO avatar Oct 13 '21 05:10 Ssu-OwO

WalletConnect can be a good addition. Can you add more details on the acceptance criteria and scope of work? I am happy to sponsor this bounty.

LeoHChen avatar Oct 16 '21 16:10 LeoHChen

Dear Leo

Nice to e-meet you. I've been in contact with Jack from your team as well!

WalletConnect is an open protocol for connecting wallets to Dapps, and therefore I believe the addition would greatly add value to Harmony's platform.

Since it's an open protocol with detailed documentation, I'd say the project could be breakdown to 3 simple stages:

  1. Research - Study documentation provided by WalletConnect.
  2. Implementation - Add WalletConnect support to Harmony's wallet connection page. Here's a link to WalletConnect's logo assets if the icon for WalletConnect is needed on the webpage. 
  3. Testing - Make sure the web frontend and mobile wallets can successfully communicate.

The addition will need future maintenance to make sure the protocol is most up-to-date though. Hope the above information helps. If you have any questions please let me know.

Ssu-OwO avatar Oct 19 '21 06:10 Ssu-OwO

I've updated the bounty with more details. We will sponsor this bounty. Thanks a lot for your input and suggestion. That's great feedbacks from the community.

LeoHChen avatar Oct 19 '21 07:10 LeoHChen

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 44474.8294 ONE (10059.67 USD @ $0.23/ONE) attached to it.

gitcoinbot avatar Oct 19 '21 07:10 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 264 years, 5 months from now. Please review their action plans below:

1) developerfred has started work.

Hi I have experience with walletconnet integrations and with harmonyOne protocol it would be a great privilege to be able to make this integration happen 2) cryptosans has started work.

To be honest, I really admire the the uniqueness of this project. Like you have to proof to dev that you want to support him and not just receive the token. It's really a planned project and I believe it'll be success. Dev you're really smart to I must commend. 3) jessicahamby has started work.

I see there are many contests in steem blockchain to review different dapps so WalletConnect team can connect with such channels to promote this Dapp through various contests. 4) bonaavidaa has started work.

İ will start this job and i do 5) jpldcarvalho has started work.

Hello. I will start working on this issue. I already checked the issue on gh and will perform the implementation according with the WalletConnect documentation. For testing, probably I will need the team help. 6) imkrish7 has started work.

Learn wallet connect and integrate with current existing code 7) theopenfinanceproject has started work.

Reverse engineer wallet connection mechanism for staking dashboard, establish best and cleanest method for integration, Then integrate.

Will start work Monday.

Hopefully done within a week or 2 depending on complexity and my availability.

Alex | OpenSwap

Learn more on the Gitcoin Issue Details page.

gitcoinbot avatar Oct 19 '21 08:10 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 44474.8294 ONE (10059.67 USD @ $0.24/ONE) has been submitted by:


gitcoinbot avatar Oct 19 '21 20:10 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 44474.8294 ONE (10514.38 USD @ $0.24/ONE) has been submitted by:

  1. @developerfred
  2. @dimas-riski
  3. @jpldcarvalho

@leohchen please take a look at the submitted work:

  • PR by @jpldcarvalho
  • PR by @dimas-riski
  • PR by @developerfred

gitcoinbot avatar Oct 19 '21 20:10 gitcoinbot

@jhd2best please help test this submission.

LeoHChen avatar Oct 20 '21 06:10 LeoHChen

@jhd2best please help test this submission.

sure. will test it these days.

btw. @developerfred do not forget finish record the video for demonstrating the function and upload to Youtube

jhd2best avatar Oct 20 '21 10:10 jhd2best

@jhd2best ok, I'm doing some tests here.

developerfred avatar Oct 20 '21 17:10 developerfred

@jhd2best done -> https://github.com/harmony-one/staking-dashboard/pull/580#issue-1030692780

developerfred avatar Oct 21 '21 19:10 developerfred

@jhd2best please help test this submission.

sure. will test it these days.

btw. @developerfred do not forget finish record the video for demonstrating the function and upload to Youtube

https://youtu.be/1UamMkS49Co

developerfred avatar Oct 22 '21 22:10 developerfred

@jhd2best please help test this submission.

sure. will test it these days. btw. @developerfred do not forget finish record the video for demonstrating the function and upload to Youtube

https://youtu.be/1UamMkS49Co

hey @developerfred . thank you for your hard work. howerver. I didn't see the key functions (such as delegate, undelegate, claim, transfer, etc.) in the video shown. can you please add it if it is convenient? This is a necessary operation to prove that the original function is normal.

jhd2best avatar Oct 23 '21 17:10 jhd2best

i have already deploy this PR(https://github.com/harmony-one/staking-dashboard/pull/580) on test environment. you can also have a testing by yourself. @developerfred https://6175723ac80df900073c1999--hmny-stake-test.netlify.app

jhd2best avatar Oct 24 '21 16:10 jhd2best

@jhd2best Thanks, I'm working on MsgDelegate, MsgUndelegate functions now

developerfred avatar Oct 25 '21 02:10 developerfred

hey @developerfred . how s it going. is there any update?

jhd2best avatar Oct 29 '21 07:10 jhd2best

hey @developerfred . how s it going. is there any update?

@jhd2best I managed to come up with a solution that would be to make transactions in Hex and only display address One on the frontend, but all transactions and interactions with walletConnect will be done in hex

developerfred avatar Oct 30 '21 22:10 developerfred

hey @developerfred . how s it going. is there any update?

jhd2best avatar Nov 09 '21 06:11 jhd2best

Hey @jhd2best I will send the new updates

developerfred avatar Nov 11 '21 12:11 developerfred

Hello @jhd2best, are you still into this issue? I have done some work on it but can't properly test it because I can't set a proper local backend environment. Can you help me out?

The npm run dev does not work, because it is not setted up in the package.json, but even if I run with tsc -w & NODE_ENV=local nodemon -q -w ./dist ./dist/server.js, I can't bootstrap it because of the gcp serviceAccount key that is needed for the database service. How do you usually setup the local environment?

Thanks !!

d-roak avatar Dec 29 '21 11:12 d-roak

@jpldcarvalho I fixed these issues, I had sent the pull request before. I just need to send an update.

developerfred avatar Dec 30 '21 20:12 developerfred

any body working on this? is it still available?

ferasawadi avatar Jan 10 '22 19:01 ferasawadi

@ferasawadi I am working on!

developerfred avatar Jan 10 '22 20:01 developerfred

@developerfred any update? been too long, other people may work on it if you have no time to finish it.

LeoHChen avatar Mar 07 '22 18:03 LeoHChen

@LeoHChen wow, I will update this pr. sorry about late

developerfred avatar Mar 08 '22 01:03 developerfred

@LeoHChen Ready now, sorry for the delay. -> https://github.com/harmony-one/staking-dashboard/pull/580

developerfred avatar Mar 08 '22 03:03 developerfred

@LeoHChen This bounty was a "Contest Permissionless" type at GitCoin. I don't think it's fair for @developerfred to be locking this bounty for months just because it sent an early (incomplete) PR. I have been waiting for months for a review... If it was a "Traditional" or "Approval Required" bounty I could agree that it was "locked" to another developer

d-roak avatar Mar 08 '22 10:03 d-roak

@jpldcarvalho as you noticed my pull request is not incomplete

developerfred avatar Mar 08 '22 11:03 developerfred

@developerfred the one 5 months ago was

d-roak avatar Mar 08 '22 11:03 d-roak