bounties icon indicating copy to clipboard operation
bounties copied to clipboard

[UX] Add ONE logo to MetaMask

Open Severino opened this issue 4 years ago • 11 comments

Description

When connected to BSC or Ethereum on MetaMask the appropriate icon of the coin is shown. On Harmony, it's currently just an empty circle.

Implement the Harmony Logo in the MetaMask extension, so that the ONE coin is shown properly. The logo can be found here: LINK TO LOGO

BSC (example) Harmony (target)
metamask-harmony-01 metamask-harmony-02

Context

MetaMask is the most used wallet. So far only BSC and Etherum have their Logos in the Extension. It would show the user, that Harmony is on the same level as those projects, when interacting with MetaMask

Acceptance Criteria

  • [ ] Implement the provided logo in MetaMask when connected to Harmony
  • [ ] Logo has proper space around the corner (compare image; in contrast BSC is a bad example, as it has no space around at all)
  • [ ] Create a pull request
  • [ ] Pull request get's accepted by the MetaMask team

Reward

$250 in ONE token

Severino avatar Aug 10 '21 09:08 Severino

Hi! Is the task still open? And any incentives associated with it? Looking forward to resolve the issue

textrocr avatar Aug 17 '21 04:08 textrocr

Hi @textrocr, thanks for your interest, it was just a idea/draft of mine so far. I have no feedback of the team yet. Therefore no incentive so far. Due to hackathon I don't expect much activity 😅 But at least you'll get github notifications when something changes.

Severino avatar Aug 17 '21 05:08 Severino

Ah! Thanks for the update!

textrocr avatar Aug 17 '21 06:08 textrocr

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1713.1465 ONE (251.33 USD @ $0.15/ONE) attached to it.

gitcoinbot avatar Sep 29 '21 04:09 gitcoinbot

This bounty is funded.

The svg files of the logo are attached.

Harmony-logo-FC-mark-small.svg.gz Harmony-logo-FC-mark.svg.gz

LeoHChen avatar Sep 29 '21 04:09 LeoHChen

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 265 years, 1 month from now. Please review their action plans below:

1) sasha21vek has started work.

Ваш логотип будет использоваться в айдентике — каждом визуальном проявлении бренда. Например, на визитках, бланках, отчётах, приглашениях, рекламе и многом другом. Наличие логотипа – необходимость для бизнеса любого размера. Даже ваш домашний бизнес может выиграть благодаря айдентике.

Learn more on the Gitcoin Issue Details page.

gitcoinbot avatar Sep 29 '21 07:09 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 265 years, 1 month from now. Please review their action plans below:

1) sasha21vek has started work.

Ваш логотип будет использоваться в айдентике — каждом визуальном проявлении бренда. Например, на визитках, бланках, отчётах, приглашениях, рекламе и многом другом. Наличие логотипа – необходимость для бизнеса любого размера. Даже ваш домашний бизнес может выиграть благодаря айдентике.

Learn more on the Gitcoin Issue Details page.

gitcoinbot avatar Sep 29 '21 07:09 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 264 years, 5 months from now. Please review their action plans below:

1) sasha21vek has started work.

Ваш логотип будет использоваться в айдентике — каждом визуальном проявлении бренда. Например, на визитках, бланках, отчётах, приглашениях, рекламе и многом другом. Наличие логотипа – необходимость для бизнеса любого размера. Даже ваш домашний бизнес может выиграть благодаря айдентике. 2) shamrat17 has started work.

Will add to the metamask-extenstion

  • Harmony icon
  • Code to load icon once connected to harmony
  • Add changelog 3) jingtings has started work.

Read through the code and update the part for icon to show 4) rohaquinlop has started work.

Read the Metamask documentation and create the PR to the repository 5) selestriel has started work.

I really have no idea how to do this ... except for a copy -paste operation from others that already submitted 6) kharroubi1 has started work.

i wil add Harmony logo on the html code of metamask , i will work on the css file so that the icon show correctly on metamask , 7) darkbladecr has started work.

As per Metamask team: "Unfortunately, we are not adding further hard coded logos at this time. We will be adding api support for this soon. That will be announced more widely, but I will also comment on this PR when that is ready."

Therefore this contest is effectively void... 8) gidr2807 has started work.

first i look for a logo and fit it in the picture. then i play some with the length height en width and if he lays exectly fine then i make him one with the picture. 9) lavender17001 has started work.

First Job G. C. Let's Give More!!! 10) lamcrytoforex has started work.

thank github i want to change my avatar 11) zaiahchon has started work.

  1. Implement the provided logo in MetaMask when connected to Harmony.
  2. Logo has proper space around the corner
  3. Create a pull request
  4. Pull request get's accepted by the MetaMask team 12) ardiferdiansah07 has started work.

i will make a toturial how to add token with image 13) mauritsarissen has started work.

First of all I'll look into how binance allowed themselves to add their icon to their chain on metamask. After that I'll try to reproduce these steps and maybe after that I'll try to officially add this to the extention.

Learn more on the Gitcoin Issue Details page.

gitcoinbot avatar Sep 29 '21 07:09 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1713.1465 ONE (265.62 USD @ $0.16/ONE) has been submitted by:


gitcoinbot avatar Sep 29 '21 11:09 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1713.1465 ONE (66.75 USD @ $0.04/ONE) has been submitted by:

  1. @textrocr
  2. @shamrat17
  3. @jingtings
  4. @ardiferdiansah07
  5. @rude69

@leohchen please take a look at the submitted work:

  • PR by @rude69
  • PR by @ardiferdiansah07
  • PR by @jingtings
  • PR by @shamrat17
  • PR by @textrocr

gitcoinbot avatar Sep 30 '21 04:09 gitcoinbot

I would suggest putting this bounty on hold. @shamrat17 created the pull request for MetaMask. The team does not merge hard-coded logos at the moment.

See: https://github.com/MetaMask/metamask-extension/pull/12245

Severino avatar Oct 05 '21 07:10 Severino