bounties icon indicating copy to clipboard operation
bounties copied to clipboard

Encode Hackathon - Bug bounty for Harmony Marketplace SDK (Documentation Error)

Open victaphu opened this issue 2 years ago • 6 comments

Description

Related to the Encode Hackathon, this bounty is for promotion of the Harmony Marketplace SDK

Context

Identify documentation errors in the Harmony Marketplace SDK and do a PR to fix the errors. Limited to 10 errors found in the SDK

Acceptance Criteria

  • [ ] Document the error found in the SDK on this bug bounty
  • [ ] Link to the PR that is pushed to the Marketplace SDK

Reward

We will reward based on the document errors found and may bundle a few errors together for payment 3 bounties up to $300 USD in ONE per bounty

victaphu avatar Sep 04 '22 06:09 victaphu

@jacksteroo please review and confirm

victaphu avatar Sep 06 '22 23:09 victaphu

Confirmed

jacksteroo avatar Sep 06 '22 23:09 jacksteroo

  • The approve, allowance and transferFrom functions in HRC20 had a wrong description
  • The contractURI function in HRC721 had a wrong description
  • tokenURI on HRC721 didn't have a parameter in the example code

PR: https://github.com/blockcoders/harmony-marketplace-sdk/pull/54

We also added more details to the documentation about the functions of HRC20, HRC721 and HRC1155 according to the methods available on the marketplace-sdk and its parameters, 🙏 please comment whether they are necessary or need to be removed.

j05u3 avatar Sep 27 '22 16:09 j05u3

hi @j05u3 thanks for the PR, let me get the blockcoders folks to confirm and we can start approving it

victaphu avatar Oct 18 '22 05:10 victaphu

hey @j05u3 did you find any other documentation improvements?

victaphu avatar Oct 18 '22 05:10 victaphu

hey @j05u3 did you find any other documentation improvements?

we couldn't find other improvements, only the ones on the PR

j05u3 avatar Oct 18 '22 05:10 j05u3