Hari Vamsi

Results 22 comments of Hari Vamsi

Hey @eliotwrobson Sorry for the delay, I was procrastinating things! I will wrap this up by tomorrow! Happy to chat about any additional changes required over slack.

hey @eliotwrobson i will finish it off. sorry for the delay. i will do this ASAP

Hey @eliotwrobson, I believe I have covered all the review items, and also added more detailed documentation. I do not know why the `CI/native-checks (pull_request)` is failing. Please let me...

> @harivamsi9 will take a look soon! The native checks are failing because of the formatting in the documentation. You have to run prettier over all of the markdown files...

> You'll need to run `make deps` first. In general, you should follow our documentation for setting up your dev environment. Pick the appropriate one depending on if you're running...

Also, just an another idea, If we know that this error usually comes up when formatting in the documentation, can we perform this `make format` command in the CI itself?...

> I see `KeyboardInterupt` in your error message, did you press Ctrl/Cmd-C while running? Did you try running `make deps` again? If that fails, other things won't work either. >...

Hey @nwalters512, sorry for the delay. Let me do a quick sprint and bring this to the finish line ASAP. Thanks for circling back on this.

Hi @eliotwrobson Hope you are doing well. I have drafted the testcases for the check_dict(), and tested the functionality under various scenarios. Here is the coverage report from pytest: ![image](https://github.com/user-attachments/assets/11ffb049-a1bf-43ae-aa83-a0f1f61a2b85)...

@eliotwrobson Thanks! Working on it!