Laravel-FTP icon indicating copy to clipboard operation
Laravel-FTP copied to clipboard

Add exceptions for more detailed error handling

Open kbasten opened this issue 5 years ago • 2 comments

kbasten avatar Apr 30 '19 12:04 kbasten

Thank you @kbasten, I will look into it this weekend.

harishanchu avatar May 02 '19 12:05 harishanchu

Hi @kbasten,

It makes sense to throw named exceptions from connection setup methods as it was throwing Exceptions even before.

Regular ftp methods are coded in way that it will always catch the exception and return false if action fails. This is convenient that we don't have to worry about wrapping regular ftp methods with try catch where ever they are called. Convince me why should we throw exceptions in regular ftp methods or please revert the changes done to changeDir method so that I can accept and merge this pull request.

harishanchu avatar May 04 '19 16:05 harishanchu