harfbuzz icon indicating copy to clipboard operation
harfbuzz copied to clipboard

Partially instancing CFF appears to work, but outlines don't vary

Open simoncozens opened this issue 1 year ago • 2 comments

% hb-subset --variations=wght=400:900 --unicodes='*' Sans/Variable/OTF/NotoSansCJKjp-VF.otf -o regbold.otf
% shape regbold.otf abc
[gid66=0+563|gid67=1+618|gid68=2+510]

shape

(This is correct at 400 weight, but:)

$ shape regbold.otf abc --variations=wght=900
[gid66=0+606|gid67=1+658|gid68=2+537]

shape

Horizontal metrics have varied correctly, outlines have not.

I don't mind if it doesn't work yet, but it should give a warning or some indication to the user.

simoncozens avatar May 07 '24 06:05 simoncozens

I thought I implemented this. Will take a look.

behdad avatar May 07 '24 14:05 behdad

Oh nevermind. I implemented full instancing, not partial instancing IIRC. It's really complicated but doable...

@qxliu76 can you add a warning or error?

behdad avatar May 07 '24 15:05 behdad