puppeteer-sharp
puppeteer-sharp copied to clipboard
hardkoded
Need Support for Mac Arm64 (Apple Silicon) Chromium Builds
Description
Need Support for Mac Arm64 (Apple Silicon) Chromium Builds
Complete minimal example reproducing the issue
n/a
Expected behavior:
n/a
Actual behavior:
n/a
Versions
Latest
Additional Information
n/a
@kblok We can't rely on Rosetta 2 being around forever. So it would be good to add the architecture as soon as it makes sense. Chromium is available for Mac_Arm64 in the same repository that Puppeteer uses today so they're ready to go.
@argentini I don't see puppeteer downloading an arm64 specific browser https://github.com/puppeteer/puppeteer/blob/main/src/node/BrowserFetcher.ts#L301
@kblok Yes, that's what I was saying. Puppeteer isn't downloading the Mac_Arm64 chromium browser yet, even though one is available. So I was wondering when the Puppeteer Sharp team would be getting around to adding support for it.
Related: https://github.com/puppeteer/puppeteer/pull/7546/files
Nice. Hopefully they'll accept this pull request. Thanks @Cheatoid !
Related: https://github.com/puppeteer/puppeteer/pull/7546/files
Nice. Hopefully they'll accept this pull request. Thanks @Cheatoid !
The pull request is accepted.
