puppeteer-sharp icon indicating copy to clipboard operation
puppeteer-sharp copied to clipboard

Published 20 hours ago • verified publisher icon hardkoded

Enable SA1201 rule

Open kblok opened this issue 5 years ago • 3 comments

Change the action for SA1201 on the ruleset file to Error, and make the solution build

kblok avatar Feb 29 '20 14:02 kblok

Are you accepting PRs to resolve these analyzer issues? I'd like to attempt this one if possible?

BL323 avatar Apr 17 '22 18:04 BL323

@BL323 go for it!

kblok avatar Apr 17 '22 23:04 kblok

I’ve raised a PR to enable the analyzer, some reordering of members was required but nothing too invasive. Let me know if there is anything I’ve missed, thanks.

BL323 avatar Apr 20 '22 06:04 BL323

@kblok Can we close these issues and similar issues? As the code has been merged, it will become easier to look into good first issue.

akshay-zz avatar Dec 25 '22 11:12 akshay-zz

@akshay-zz yes!

kblok avatar Dec 26 '22 14:12 kblok