webb icon indicating copy to clipboard operation
webb copied to clipboard

Redundant functions

Open DrNightmare opened this issue 10 years ago • 1 comments

find_next_link() and get_next_link() are identical functions, one of them can be removed. Same goes for find_all_links_as_list() and get_all_links().

Also, instead of get_next_link(), get_next_heading(), get_next_paragraph(), etc. being separate functions, it could be a single function, get_next_element() or so, which takes a string ('img', 'p', 'a', ..) as a parameter. This would significantly reduce code size.

DrNightmare avatar Aug 06 '15 08:08 DrNightmare

Definately planned for it! Currently some functions are used by user-model while others are used by internal crawler functions. So once that is synced, merging of functions will be possible! Thanks!

Marking it as and enhancement.

hardikvasa avatar Aug 07 '15 14:08 hardikvasa