hardfist
hardfist
> This fixed the issue for me: > > ```diff > index c78273a3f..906abb084 100644 > --- a/packages/rspack/src/node/NodeWatchFileSystem.ts > +++ b/packages/rspack/src/node/NodeWatchFileSystem.ts > @@ -62,8 +62,9 @@ export default class NodeWatchFileSystem implements...
@escaton the new import file and its dependencies will be insert into the new files set in the done hook, so the watcher can watch it
> But in order for watcher to start watching it, the `Watchpack::watch` needs to be called. yes, https://github.com/web-infra-dev/rspack/issues/7490#issuecomment-2273955633 did call watch
we do have dirty flag in compilation and we can check whether dependencies change before call watch
> Can you point where to look? I check the code, and not record update dependencies info, we will add related api soon
> @jerrykingxyz @hardfist Since the added/removed compilation dependencies are now exposed, I can contribute the fix for the watcher, if you haven't started working on it yet. @escaton we haven't...
bump, I think we will solve this problem by using nativeWatcher
it's actually same issue as https://github.com/webpack/sass-loader/issues/1244 which behaves same as webpack + worker-loader, so the real problem is * worker-loader doesn't call childCompiler.close() * sass-loader use shutdown hooks which may...
does this bug still exists in latest rspack version @hverlin ?