python-can icon indicating copy to clipboard operation
python-can copied to clipboard

To integrate a TOSUN CAN device

Open sy950915 opened this issue 1 year ago • 5 comments

Hello, I am an employee of Shanghai Tongxing Intelligent Technology Co., Ltd. We are interested in integrating our company's device into Python-can. Currently, many users are requesting the ability to use our device directly within Python-can. At present, we achieve this by installing Python-can and then adding our own files into the Python-can directory to enable this functionality. However, this approach is not as seamless as having our device fully integrated into Python-can, and we are looking for a more convenient solution.

sy950915 avatar Oct 15 '24 04:10 sy950915

Hi, you can create and publish your own package, which python-cans entry point as described here. We will add your package as an extra dependency and mention it in our documentation.

zariiii9003 avatar Oct 15 '24 06:10 zariiii9003

@zariiii9003 Hello, at the moment, our approach requires users to first install Python-can and then configure it manually in order to use our device. We would like to discuss the possibility of directly integrating our device into Python-can, so that users can install Python-can via pip and use our device without any additional configuration—similar to how Vector devices are supported.

sy950915 avatar Oct 15 '24 06:10 sy950915

Your users would install your package as an extra dependency with pip install python-can[tosun]. No additional configuration necessary.

zariiii9003 avatar Oct 15 '24 06:10 zariiii9003

@zariiii9003 Alright, thank you very much. I will take some time to research this further. I greatly appreciate your response.

sy950915 avatar Oct 15 '24 06:10 sy950915

I've manually added your compatible python file to python-can @sy950915 ,There were a few small problem. I changed some code manually for TOSUN. I hope the next version of python-can, tosun will be officially supported. Python-can is the most popular library in python, so focus on it, (- v -)

luojiaaoo avatar Oct 21 '24 15:10 luojiaaoo