ASCReader does not support ASC format since V8.1

Open Tian-Jionglu opened this issue 2 years ago • 2 comments

Describe the bug

ASCReader in python-can 4.1.0 doesn't support ASC CANFD format since V8.1, since <symbolic_name> name is missing in code. According to the document from Vector <can_log_trigger_asc_format.pdf>, there should be <SYMBOLIC_NAME> between <ID> and <BRS>.

To Reproduce

Use python-can to read CANFD message in asc log since format V8.1.

Expected behavior

Reading process stopped with CANFD message.

Additional context

I made a quick fix in a forked branch. I think an overall fix about ASC format IO is needed in this issue.

OS and version: Python version: python-can version: python-can interface/s (if applicable):

Traceback and logs

Mar 03 '23 08:03 Tian-Jionglu

Since you have the format description, could you provide a backwards compatible solution as a PR?

Mar 06 '23 22:03 zariiii9003

see PR #1641 , cause of my misunderstanding of ASC logging.

Jun 11 '24 05:06 Tian-Jionglu